Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Obs AI Assistant] Unskip user instructions test (#205656) (#205897) #206082

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

we don't need title interception for\r\nthese tests\r\n\r\n### Checklist\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"37d7a5efb760dc271a4fb26f1eeba0d66e037b07","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Obs AI Assistant","ci:project-deploy-observability","backport:version","v8.18.0"],"title":"[Obs AI Assistant] Unskip user instructions test (#205656)","number":205897,"url":"https://github.com//pull/205897","mergeCommit":{"message":"[Obs AI Assistant] Unskip user instructions test (#205656) (#205897)\n\nCloses https://github.com//issues/205656\r\n\r\n## Summary\r\n\r\n### Problem\r\nThere seems to be a race condition and state contamination between tests\r\nin the KB user instructions tests.\r\n\r\n### Solution\r\n- Clear knowledge base and conversations after tests\r\n- Remove title interceptor --> we don't need title interception for\r\nthese tests\r\n\r\n### Checklist\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"37d7a5efb760dc271a4fb26f1eeba0d66e037b07"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com//pull/205897","number":205897,"mergeCommit":{"message":"[Obs AI Assistant] Unskip user instructions test (#205656) (#205897)\n\nCloses https://github.com//issues/205656\r\n\r\n## Summary\r\n\r\n### Problem\r\nThere seems to be a race condition and state contamination between tests\r\nin the KB user instructions tests.\r\n\r\n### Solution\r\n- Clear knowledge base and conversations after tests\r\n- Remove title interceptor --> we don't need title interception for\r\nthese tests\r\n\r\n### Checklist\r\n\r\n- [x] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"37d7a5efb760dc271a4fb26f1eeba0d66e037b07"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

Copy link
Contributor

github-actions bot commented Jan 9, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

…astic#205897)

Closes elastic#205656

## Summary

### Problem
There seems to be a race condition and state contamination between tests
in the KB user instructions tests.

### Solution
- Clear knowledge base and conversations after tests
- Remove title interceptor --> we don't need title interception for
these tests

### Checklist

- [x] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [x] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 37d7a5e)
@viduni94 viduni94 force-pushed the backport/8.x/pr-205897 branch from 5522caf to 83dafe8 Compare January 10, 2025 16:33
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 10, 2025

💚 Build Succeeded

  • Buildkite Build
  • Commit: 83dafe8
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-206082-83dafe8b6f56

Metrics [docs]

✅ unchanged

History

cc @viduni94

@kibanamachine kibanamachine merged commit 6cb4049 into elastic:8.x Jan 10, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants