SKA: Relocate remaining modules #206103

gsoldevila · 2025-01-09T16:32:22Z

Summary

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the Sustainable Kibana Architecture initiative.

Important

We kindly ask you to:
- Manually fix the errors in the error section below (if there are any).
- Search for the packages[\/\\] and plugins[\/\\] patterns in the source code (Babel and Eslint config files), and update them appropriately.
- Manually review .buildkite/scripts/pipelines/pull_request/pipeline.ts to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names
- Review all of the updated files, specially the .ts and .js files listed in the sections below, as some of them contain relative paths that have been updated.
- Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.:
  - customised eslint rules
  - docs pointing to source code

Note

This PR has been auto-generated.
Any manual contributions will be lost if the 'relocate' script is re-run.
Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash.
Please use #sustainable_kibana_architecture Slack channel for feedback.

Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe here.

2 plugin(s) are going to be relocated:

Id	Target folder
`@kbn/entities-data-access-plugin`	`x-pack/solutions/observability/plugins/entities_data_access`
`@kbn/entityManager-app-plugin`	`x-pack/solutions/observability/plugins/entity_manager_app`

10 packages(s) are going to be relocated:

Id	Target folder
`@kbn/core-user-settings-server`	`src/core/packages/user-settings/server`
`@kbn/core-user-settings-server-internal`	`src/core/packages/user-settings/server-internal`
`@kbn/core-user-settings-server-mocks`	`src/core/packages/user-settings/server-mocks`
`@kbn/calculate-auto`	`src/platform/packages/shared/kbn-calculate-auto`
`@kbn/charts-theme`	`src/platform/packages/shared/kbn-charts-theme`
`@kbn/palettes`	`src/platform/packages/shared/kbn-palettes`
`@kbn/saved-search-component`	`src/platform/packages/shared/kbn-saved-search-component`
`@kbn/use-tracked-promise`	`src/platform/packages/shared/kbn-use-tracked-promise`
`@kbn/response-ops-rule-form`	`src/platform/packages/shared/response-ops/rule_form`
`@kbn/streams-schema`	`x-pack/solutions/observability/packages/kbn-streams-schema`

Updated references

./.i18nrc.json
./docs/developer/plugin-list.asciidoc
./package.json
./packages/kbn-ts-projects/config-paths.json
./src/core/packages/user-settings/server-internal/jest.config.js
./src/core/packages/user-settings/server-mocks/jest.config.js
./src/platform/packages/private/kbn-repo-packages/package-map.json
./src/platform/packages/shared/kbn-calculate-auto/jest.config.js
./src/platform/packages/shared/kbn-charts-theme/jest.config.js
./src/platform/packages/shared/kbn-palettes/jest.config.js
./src/platform/packages/shared/kbn-saved-search-component/jest.config.js
./src/platform/packages/shared/kbn-use-tracked-promise/jest.config.js
./src/platform/packages/shared/response-ops/rule_form/jest.config.js
./tsconfig.base.json
./x-pack/solutions/observability/packages/kbn-streams-schema/jest.config.js
./x-pack/solutions/observability/plugins/entities_data_access/jest.config.js
./x-pack/solutions/observability/plugins/entity_manager_app/jest.config.js
./yarn.lock
.github/CODEOWNERS

Updated relative paths

src/core/packages/user-settings/server-internal/jest.config.js:12
src/core/packages/user-settings/server-internal/tsconfig.json:2
src/core/packages/user-settings/server-mocks/jest.config.js:12
src/core/packages/user-settings/server-mocks/tsconfig.json:2
src/core/packages/user-settings/server/tsconfig.json:2
src/platform/packages/shared/kbn-calculate-auto/jest.config.js:12
src/platform/packages/shared/kbn-calculate-auto/tsconfig.json:2
src/platform/packages/shared/kbn-charts-theme/jest.config.js:12
src/platform/packages/shared/kbn-charts-theme/tsconfig.json:2
src/platform/packages/shared/kbn-palettes/jest.config.js:12
src/platform/packages/shared/kbn-palettes/tsconfig.json:2
src/platform/packages/shared/kbn-saved-search-component/jest.config.js:12
src/platform/packages/shared/kbn-saved-search-component/tsconfig.json:2
src/platform/packages/shared/kbn-use-tracked-promise/jest.config.js:12
src/platform/packages/shared/kbn-use-tracked-promise/tsconfig.json:2
src/platform/packages/shared/response-ops/rule_form/jest.config.js:12
src/platform/packages/shared/response-ops/rule_form/tsconfig.json:2
x-pack/solutions/observability/packages/kbn-streams-schema/jest.config.js:10
x-pack/solutions/observability/packages/kbn-streams-schema/tsconfig.json:2
x-pack/solutions/observability/plugins/entities_data_access/jest.config.js:12
x-pack/solutions/observability/plugins/entities_data_access/tsconfig.json:2
x-pack/solutions/observability/plugins/entity_manager_app/jest.config.js:12
x-pack/solutions/observability/plugins/entity_manager_app/tsconfig.json:2
x-pack/solutions/observability/plugins/entity_manager_app/tsconfig.json:7

github-actions · 2025-01-09T16:32:37Z

A documentation preview will be available soon.

🔨 Buildkite builds
📚 HTML diff
📙 Preview page

Request a new doc build by commenting

Rebuild this PR: run docs-build
Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

elasticmachine · 2025-01-10T09:33:24Z

Pinging @elastic/kibana-core (Team:Core)

pheyos

packages/kbn-test/jest-preset.js changes LGTM

…-fix'

elasticmachine · 2025-01-11T10:54:29Z

💚 Build Succeeded

Buildkite Build
Commit: 6b4045e

Metrics [docs]

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`@kbn/core`	822	825	+3
`@kbn/core-user-settings-server-internal`	2	0	-2
total			+1

History

💛 Build #266046 was flaky f4e2751
💔 Build #266021 failed 88cd113
💔 Build #265906 failed f38cad6
💔 Build #265711 failed 68fc256

flash1293

LGTM, code review only

kibanamachine · 2025-01-13T08:12:47Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12743069644

kibanamachine · 2025-01-13T08:17:59Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 206103

Questions ?

Please refer to the Backport tool documentation

flash1293 · 2025-01-13T08:19:20Z

@gsoldevila there are a couple of backports missing for streams stuff which probably failed this backport. I'm currently working through them.

kibanamachine · 2025-01-13T13:38:53Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12748445919

kibanamachine · 2025-01-13T13:38:53Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12748445996

kibanamachine · 2025-01-13T13:44:09Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 206103

Questions ?

Please refer to the Backport tool documentation

kibanamachine · 2025-01-13T13:49:56Z

💔 All backports failed

Status	Branch	Result
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 206103

Questions ?

Please refer to the Backport tool documentation

This PR aims at relocating some of the Kibana modules (plugins and packages) into a new folder structure, according to the _Sustainable Kibana Architecture_ initiative. > [!IMPORTANT] > * We kindly ask you to: > * Manually fix the errors in the error section below (if there are any). > * Search for the `packages[\/\\]` and `plugins[\/\\]` patterns in the source code (Babel and Eslint config files), and update them appropriately. > * Manually review `.buildkite/scripts/pipelines/pull_request/pipeline.ts` to ensure that any CI pipeline customizations continue to be correctly applied after the changed path names > * Review all of the updated files, specially the `.ts` and `.js` files listed in the sections below, as some of them contain relative paths that have been updated. > * Think of potential impact of the move, including tooling and configuration files that can be pointing to the relocated modules. E.g.: > * customised eslint rules > * docs pointing to source code > [!NOTE] > * This PR has been auto-generated. > * Any manual contributions will be lost if the 'relocate' script is re-run. > * Try to obtain the missing reviews / approvals before applying manual fixes, and/or keep your changes in a .patch / git stash. > * Please use [#sustainable_kibana_architecture](https://elastic.slack.com/archives/C07TCKTA22E) Slack channel for feedback. Are you trying to rebase this PR to solve merge conflicts? Please follow the steps describe [here](https://elastic.slack.com/archives/C07TCKTA22E/p1734019532879269?thread_ts=1734019339.935419&cid=C07TCKTA22E). | Id | Target folder | | -- | ------------- | | `@kbn/entities-data-access-plugin` | `x-pack/solutions/observability/plugins/entities_data_access` | | `@kbn/entityManager-app-plugin` | `x-pack/solutions/observability/plugins/entity_manager_app` | | Id | Target folder | | -- | ------------- | | `@kbn/core-user-settings-server` | `src/core/packages/user-settings/server` | | `@kbn/core-user-settings-server-internal` | `src/core/packages/user-settings/server-internal` | | `@kbn/core-user-settings-server-mocks` | `src/core/packages/user-settings/server-mocks` | | `@kbn/calculate-auto` | `src/platform/packages/shared/kbn-calculate-auto` | | `@kbn/charts-theme` | `src/platform/packages/shared/kbn-charts-theme` | | `@kbn/palettes` | `src/platform/packages/shared/kbn-palettes` | | `@kbn/saved-search-component` | `src/platform/packages/shared/kbn-saved-search-component` | | `@kbn/use-tracked-promise` | `src/platform/packages/shared/kbn-use-tracked-promise` | | `@kbn/response-ops-rule-form` | `src/platform/packages/shared/response-ops/rule_form` | | `@kbn/streams-schema` | `x-pack/solutions/observability/packages/kbn-streams-schema` | <details > <summary>Updated references</summary> ``` ./.i18nrc.json ./docs/developer/plugin-list.asciidoc ./package.json ./packages/kbn-ts-projects/config-paths.json ./src/core/packages/user-settings/server-internal/jest.config.js ./src/core/packages/user-settings/server-mocks/jest.config.js ./src/platform/packages/private/kbn-repo-packages/package-map.json ./src/platform/packages/shared/kbn-calculate-auto/jest.config.js ./src/platform/packages/shared/kbn-charts-theme/jest.config.js ./src/platform/packages/shared/kbn-palettes/jest.config.js ./src/platform/packages/shared/kbn-saved-search-component/jest.config.js ./src/platform/packages/shared/kbn-use-tracked-promise/jest.config.js ./src/platform/packages/shared/response-ops/rule_form/jest.config.js ./tsconfig.base.json ./x-pack/solutions/observability/packages/kbn-streams-schema/jest.config.js ./x-pack/solutions/observability/plugins/entities_data_access/jest.config.js ./x-pack/solutions/observability/plugins/entity_manager_app/jest.config.js ./yarn.lock .github/CODEOWNERS ``` </details><details > <summary>Updated relative paths</summary> ``` src/core/packages/user-settings/server-internal/jest.config.js:12 src/core/packages/user-settings/server-internal/tsconfig.json:2 src/core/packages/user-settings/server-mocks/jest.config.js:12 src/core/packages/user-settings/server-mocks/tsconfig.json:2 src/core/packages/user-settings/server/tsconfig.json:2 src/platform/packages/shared/kbn-calculate-auto/jest.config.js:12 src/platform/packages/shared/kbn-calculate-auto/tsconfig.json:2 src/platform/packages/shared/kbn-charts-theme/jest.config.js:12 src/platform/packages/shared/kbn-charts-theme/tsconfig.json:2 src/platform/packages/shared/kbn-palettes/jest.config.js:12 src/platform/packages/shared/kbn-palettes/tsconfig.json:2 src/platform/packages/shared/kbn-saved-search-component/jest.config.js:12 src/platform/packages/shared/kbn-saved-search-component/tsconfig.json:2 src/platform/packages/shared/kbn-use-tracked-promise/jest.config.js:12 src/platform/packages/shared/kbn-use-tracked-promise/tsconfig.json:2 src/platform/packages/shared/response-ops/rule_form/jest.config.js:12 src/platform/packages/shared/response-ops/rule_form/tsconfig.json:2 x-pack/solutions/observability/packages/kbn-streams-schema/jest.config.js:10 x-pack/solutions/observability/packages/kbn-streams-schema/tsconfig.json:2 x-pack/solutions/observability/plugins/entities_data_access/jest.config.js:12 x-pack/solutions/observability/plugins/entities_data_access/tsconfig.json:2 x-pack/solutions/observability/plugins/entity_manager_app/jest.config.js:12 x-pack/solutions/observability/plugins/entity_manager_app/tsconfig.json:2 x-pack/solutions/observability/plugins/entity_manager_app/tsconfig.json:7 ``` </details> --------- Co-authored-by: kibanamachine <[email protected]>

## Summary Backport #206103 by re-running the `relocate` script --------- Co-authored-by: kibanamachine <[email protected]>

rudolf added the plugin groups Relocate all plugins and packages under their respective platform/solution groups label Jan 10, 2025

gsoldevila force-pushed the kbn-team-1309-relocate-20250109153436 branch from a14acc1 to f38cad6 Compare January 10, 2025 09:29

gsoldevila marked this pull request as ready for review January 10, 2025 09:33

gsoldevila requested review from a team as code owners January 10, 2025 09:33

shahzad31 approved these changes Jan 10, 2025

View reviewed changes

pheyos approved these changes Jan 10, 2025

View reviewed changes

wayneseymour approved these changes Jan 10, 2025

View reviewed changes

dokmic approved these changes Jan 10, 2025

View reviewed changes

markov00 approved these changes Jan 10, 2025

View reviewed changes

gsoldevila force-pushed the kbn-team-1309-relocate-20250109153436 branch from f38cad6 to 88cd113 Compare January 10, 2025 13:09

gsoldevila removed request for a team January 10, 2025 13:09

gsoldevila and others added 11 commits January 11, 2025 10:29

Relocating module @kbn/core-user-settings-server-mocks

480ae84

Relocating module @kbn/calculate-auto

da35657

Relocating module @kbn/charts-theme

45afaec

Relocating module @kbn/palettes

24f3cdd

Relocating module @kbn/saved-search-component

2edf6f2

Relocating module @kbn/use-tracked-promise

f651eb4

Relocating module @kbn/response-ops-rule-form

fe081bc

Relocating module @kbn/streams-schema

193f5f5

Relocating module @kbn/entities-data-access-plugin

7c6e272

Relocating module @kbn/entityManager-app-plugin

ad9f013

[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…

6b4045e

…-fix'

gsoldevila force-pushed the kbn-team-1309-relocate-20250109153436 branch from f4e2751 to 6b4045e Compare January 11, 2025 09:33

flash1293 approved these changes Jan 13, 2025

View reviewed changes

gsoldevila merged commit 683a768 into elastic:main Jan 13, 2025
8 checks passed

kibanamachine added the v9.0.0 label Jan 13, 2025

flash1293 removed the backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) label Jan 13, 2025

kibanamachine added the backport:skip This commit does not require backporting label Jan 13, 2025

flash1293 added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Jan 13, 2025

gsoldevila mentioned this pull request Jan 13, 2025

[8.x] SKA: Relocate remaining modules (#206103) #206471

Merged

gsoldevila added a commit that referenced this pull request Jan 14, 2025

[8.x] SKA: Relocate remaining modules (#206103) (#206471)

5480b80

## Summary Backport #206103 by re-running the `relocate` script --------- Co-authored-by: kibanamachine <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SKA: Relocate remaining modules #206103

SKA: Relocate remaining modules #206103

gsoldevila commented Jan 9, 2025 •

edited by kibanamachine

Loading

github-actions bot commented Jan 9, 2025

elasticmachine commented Jan 10, 2025

pheyos left a comment

elasticmachine commented Jan 11, 2025

flash1293 left a comment

kibanamachine commented Jan 13, 2025

kibanamachine commented Jan 13, 2025

flash1293 commented Jan 13, 2025

kibanamachine commented Jan 13, 2025

kibanamachine commented Jan 13, 2025

kibanamachine commented Jan 13, 2025

kibanamachine commented Jan 13, 2025

SKA: Relocate remaining modules #206103

SKA: Relocate remaining modules #206103

Conversation

gsoldevila commented Jan 9, 2025 • edited by kibanamachine Loading

Summary

2 plugin(s) are going to be relocated:

10 packages(s) are going to be relocated:

github-actions bot commented Jan 9, 2025

elasticmachine commented Jan 10, 2025

pheyos left a comment

Choose a reason for hiding this comment

elasticmachine commented Jan 11, 2025

💚 Build Succeeded

Metrics [docs]

Public APIs missing exports

History

flash1293 left a comment

Choose a reason for hiding this comment

kibanamachine commented Jan 13, 2025

kibanamachine commented Jan 13, 2025

💔 All backports failed

Manual backport

Questions ?

flash1293 commented Jan 13, 2025

kibanamachine commented Jan 13, 2025

kibanamachine commented Jan 13, 2025

kibanamachine commented Jan 13, 2025

💔 All backports failed

Manual backport

Questions ?

kibanamachine commented Jan 13, 2025

💔 All backports failed

Manual backport

Questions ?

gsoldevila commented Jan 9, 2025 •

edited by kibanamachine

Loading