Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Update dependency @elastic/charts to v68.0.4 (main) (#203955) #206127

Merged
merged 7 commits into from
Jan 11, 2025

Conversation

nickofthyme
Copy link
Contributor

@nickofthyme nickofthyme commented Jan 9, 2025

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [@elastic/charts](https://togithub.com/elastic/elastic-charts) |
dependencies | patch | [`68.0.3` ->
`68.0.4`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/68.0.3/68.0.4)
|

This version of charts exports a helper function to correct an issue
with the chart background color for the new Borealis theme. In addition
to this we created a simplified hook `useElasticChartsTheme` from the
`@kbn/charts-theme` package which reads the `euiTheme`.

```diff
-import { Chart, Settings, LIGHT_THEME, DARK_THEME } from '@elastic/charts';
+import { Chart, Settings } from '@elastic/charts';
-import { useEuiTheme } from '@elastic/eui';

+import { useElasticChartsTheme } from '@kbn/charts-theme';

 export function MyComponent() {
-  const euiTheme = useEuiTheme();
-  const baseTheme = euiTheme.colorMode === 'LIGHT' ? LIGHT_THEME : DARK_THEME;
+  const baseTheme = useElasticChartsTheme();

   return (
     <Chart>
       <Settings
         baseTheme={baseTheme}
         {/* ... */}
       />
       {/* ... */}
     </Chart>
   )
 }
```

---

### Release Notes

<details>
<summary>elastic/elastic-charts (@&elastic#8203;elastic/charts)</summary>

###
[`v68.0.4`](https://togithub.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6804-2024-12-11)

[Compare
Source](https://togithub.com/elastic/elastic-charts/compare/v68.0.3...v68.0.4)

##### Bug Fixes

- **xy:** compute per series and global minPointsDistance
([#&elastic#8203;2571](https://togithub.com/elastic/elastic-charts/issues/2571))
([8dae2c1](https://togithub.com/elastic/elastic-charts/commit/8dae2c1f4c99146aa757b2d3eec9d72846248cc7))

##### Performance Improvements

- fix unnecessary re-render
([#&elastic#8203;2573](https://togithub.com/elastic/elastic-charts/issues/2573))
([feacfd6](https://togithub.com/elastic/elastic-charts/commit/feacfd6247b9580a8d32bc5d6284329b2035c1ba))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjUuMSIsInVwZGF0ZWRJblZlciI6IjM3LjQyNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJUZWFtOlZpc3VhbGl6YXRpb25zIiwiYmFja3BvcnQ6cHJldi1taW5vciIsInJlbGVhc2Vfbm90ZTpza2lwIl19-->

---------

Co-authored-by: elastic-renovate-prod[bot] <174716857+elastic-renovate-prod[bot]@users.noreply.github.com>
Co-authored-by: nickofthyme <[email protected]>
Co-authored-by: adcoelho <[email protected]>
Co-authored-by: Marco Vettorello <[email protected]>
Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit 841bf73)

# Conflicts:
#	.github/CODEOWNERS
#	package.json
#	x-pack/platform/plugins/shared/ml/tsconfig.json
#	x-pack/solutions/observability/plugins/apm/public/components/alerting/ui_components/chart_preview/index.tsx
#	x-pack/solutions/observability/plugins/apm/public/components/app/error_group_details/distribution/index.tsx
#	x-pack/solutions/observability/plugins/infra/public/alerting/log_threshold/components/alert_details_app_section/index.tsx
#	x-pack/solutions/observability/plugins/infra/tsconfig.json
#	x-pack/solutions/observability/plugins/observability_shared/public/hooks/use_chart_theme.tsx
#	x-pack/solutions/observability/plugins/synthetics/tsconfig.json
#	x-pack/solutions/observability/plugins/uptime/tsconfig.json
#	x-pack/solutions/security/plugins/security_solution/tsconfig.json
@nickofthyme nickofthyme enabled auto-merge (squash) January 9, 2025 18:19
@botelastic botelastic bot added Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team labels Jan 9, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

kibanamachine and others added 4 commits January 9, 2025 18:45
…t --include-path /api/status --include-path /api/alerting/rule/ --include-path /api/alerting/rules --include-path /api/actions --include-path /api/security/role --include-path /api/spaces --include-path /api/dashboards --update --no-serverless'
@elastic elastic deleted a comment from elasticmachine Jan 10, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 10, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
apm 1689 1690 +1
dashboard 675 676 +1
dataUsage 119 120 +1
eventAnnotationListing 584 585 +1
filesManagement 180 181 +1
graph 292 293 +1
infra 1528 1529 +1
maps 1249 1250 +1
ml 2122 2123 +1
observabilityAIAssistantApp 418 419 +1
observabilityShared 231 232 +1
securitySolution 6519 6520 +1
visualizations 484 485 +1
total +13

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
apm 2.6MB 2.6MB +504.0B
dashboard 666.4KB 666.5KB +85.0B
dataUsage 237.3KB 237.4KB +90.0B
eventAnnotationListing 231.0KB 231.0KB +84.0B
filesManagement 122.3KB 122.3KB +84.0B
graph 414.2KB 414.3KB +84.0B
infra 1.8MB 1.8MB +73.0B
maps 3.0MB 3.0MB +84.0B
ml 4.7MB 4.7MB +39.0B
observabilityAIAssistantApp 299.0KB 299.1KB +180.0B
securitySolution 19.2MB 19.2MB +85.0B
synthetics 917.6KB 917.7KB +180.0B
uptime 466.1KB 466.2KB +55.0B
visualizations 327.3KB 327.4KB +84.0B
total +1.7KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-npmDll 5.9MB 5.9MB +1.4KB
observabilityShared 94.3KB 94.4KB +115.0B
total +1.6KB
Unknown metric groups

API count

id before after diff
@kbn/charts-theme - 1 +1

History

@nickofthyme nickofthyme merged commit 892f68d into elastic:8.x Jan 11, 2025
9 checks passed
@nickofthyme nickofthyme deleted the backport/8.x/pr-203955 branch January 11, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team Team:obs-ux-management Observability Management User Experience Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants