-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Response Ops] [Rule Form] Add new flyout to rule form library, responsive design and illustration to rule form page #206141
Open
Zacqary
wants to merge
13
commits into
elastic:main
Choose a base branch
from
Zacqary:195211-new-flyout
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,818
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacqary
added
release_note:enhancement
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
v9.0.0
Feature:Alerting/RulesManagement
Issues related to the Rules Management UX
backport:version
Backport to applied version labels
v8.18.0
labels
Jan 9, 2025
Zacqary
force-pushed
the
195211-new-flyout
branch
from
January 9, 2025 21:24
949400a
to
d8f9597
Compare
2 tasks
Zacqary
force-pushed
the
195211-new-flyout
branch
from
January 10, 2025 21:10
cd366f6
to
fd856f3
Compare
Pinging @elastic/response-ops (Team:ResponseOps) |
@elastic/kibana-design In addition to the SCSS file that triggered CODEOWNER, please take a look at the SVG file I pulled from the Figma designs for this feature and let me know if it's good to go. |
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:version
Backport to applied version labels
Feature:Alerting/RulesManagement
Issues related to the Rules Management UX
release_note:enhancement
Team:ResponseOps
Label for the ResponseOps team (formerly the Cases and Alerting teams)
v8.18.0
v9.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #195211
Adds components for the new rule form flyout, and duplicates some of its design elements as responsive design on the Rule Page. This PR makes use of CSS
@container
queries, which EUI doesn't yet support natively. I've opened elastic/eui#8265 to get native EUI support for this functionality, but for now we can apply it through class names and SCSS.The reason we're using
@container
is so the Rule Form can be responsive regardless of whether it's bound by the window size (in the case of the Rule Page) or a container element on a larger screen (in the Rule Flyout). When responsive design just relies on@media screen
queries, we can have a situation where we're trying to render the rule form in a 500px wide flyout, but because the window is 1920px wide, it still tries to apply wide screen styling.@container
instead responds to the width of an enclosing element, which can either be the body of the Rule Page, or the width of the Rule Flyout.Non-User Facing Changes
@kbn/response-ops-rule-form
. It is not yet actually user-facing anywhere in the application, this will be done in a second PR.Screenshots
User-Facing Changes
These changes were added to the existing full page rule form to minimize the amount of code differences between the flyout and the full page
Screenshot
Screenshot
Testing
To test the new flyout, edit
packages/response-ops/rule_form/src/create_rule_form.tsx
andpackages/response-ops/rule_form/src/edit_rule_form.tsx
so that they render<RuleFlyout>
instead of<RulePage>
.Use this diff block
Still Todo
Checklist