Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Security:Manage:EntityAnalytics:EntityStore] missing labels on Entity store page #207400

Merged
merged 4 commits into from
Jan 30, 2025
Merged

fix: [Security:Manage:EntityAnalytics:EntityStore] missing labels on Entity store page #207400

merged 4 commits into from
Jan 30, 2025

Conversation

alexwizp
Copy link
Contributor

@alexwizp alexwizp commented Jan 21, 2025 •
edited by kibanamachine
Loading

Closes: #205826
Closes: #205825

Description
Import entities input file upload box is missing label on entity store page.

Preconditions
Security -> Manage ->Entity store page

Steps to reproduce

  1. Open Entity store page
  2. Run axe-core through the page

Changes made

  1. added required aria-label attributes for mentioned places

Screen

image

@alexwizp
Copy link
Contributor Author

/ci

@alexwizp alexwizp added v9.0.0 release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Project:Accessibility labels Jan 21, 2025
@alexwizp alexwizp marked this pull request as ready for review January 21, 2025 16:40
@alexwizp alexwizp requested a review from a team as a code owner January 21, 2025 16:40
@alexwizp alexwizp requested a review from CAWilson94 January 21, 2025 16:40
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 21.3MB 21.3MB +160.0B

History

@alexwizp
Merge remote-tracking branch 'upstream/main' into elastic#205825
d68edda 
# Conflicts:
#	x-pack/solutions/security/plugins/security_solution/public/entity_analytics/pages/entity_store_management_page.tsx
@alexwizp
Copy link
Contributor Author

@CAWilson94 please have a look

CAWilson94
CAWilson94 approved these changes Jan 30, 2025
View reviewed changes
Copy link
Contributor

@CAWilson94 CAWilson94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Alex! I Desk tested, and I can confirm that the main branch with Axe tools reports 2 issues, while the PR branch now reports 0. 🎉 Great work!

@alexwizp alexwizp merged commit 50272d6 into elastic:main Jan 30, 2025
8 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/13048940648

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Jan 30, 2025
@alexwizp
fix: [Security:Manage:EntityAnalytics:EntityStore] missing labels on …
ba513a6 
…Entity store page (elastic#207400)

Closes: elastic#205826
Closes: elastic#205825

**Description**
Import entities input file upload box is missing label on entity store
page.

**Preconditions**
Security -> Manage ->Entity store page

**Steps to reproduce**
1. Open Entity store page
2. Run axe-core through the page

**Changes made**
1. added required `aria-label` attributes for mentioned places

**Screen**

<img width="1223" alt="image"
src="https://github.com/user-attachments/assets/29a76c2c-76f6-4bdc-b3f4-4feefc4009eb"
/>

(cherry picked from commit 50272d6)
@kibanamachine kibanamachine mentioned this pull request Jan 30, 2025
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Jan 30, 2025
@kibanamachine @alexwizp
[8.x] fix: [Security:Manage:EntityAnalytics:EntityStore] missing labe…
963cc41 
…ls on Entity store page (#207400) (#208888)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Security:Manage:EntityAnalytics:EntityStore] missing labels on
Entity store page
(#207400)](#207400)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-30T09:05:22Z","message":"fix:
[Security:Manage:EntityAnalytics:EntityStore] missing labels on Entity
store page (#207400)\n\nCloses: #205826\r\nCloses:
#205825\r\n\r\n**Description**\r\nImport entities input file upload box
is missing label on entity
store\r\npage.\r\n\r\n**Preconditions**\r\nSecurity -> Manage ->Entity
store page\r\n\r\n**Steps to reproduce**\r\n1. Open Entity store
page\r\n2. Run axe-core through the page\r\n\r\n**Changes made**\r\n1.
added required `aria-label` attributes for mentioned
places\r\n\r\n**Screen**\r\n\r\n<img width=\"1223\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/29a76c2c-76f6-4bdc-b3f4-4feefc4009eb\"\r\n/>","sha":"50272d651bab2ec56f3149e7fad91de79048e05a","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","backport:prev-minor"],"title":"fix:
[Security:Manage:EntityAnalytics:EntityStore] missing labels on Entity
store
page","number":207400,"url":"https://github.com/elastic/kibana/pull/207400","mergeCommit":{"message":"fix:
[Security:Manage:EntityAnalytics:EntityStore] missing labels on Entity
store page (#207400)\n\nCloses: #205826\r\nCloses:
#205825\r\n\r\n**Description**\r\nImport entities input file upload box
is missing label on entity
store\r\npage.\r\n\r\n**Preconditions**\r\nSecurity -> Manage ->Entity
store page\r\n\r\n**Steps to reproduce**\r\n1. Open Entity store
page\r\n2. Run axe-core through the page\r\n\r\n**Changes made**\r\n1.
added required `aria-label` attributes for mentioned
places\r\n\r\n**Screen**\r\n\r\n<img width=\"1223\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/29a76c2c-76f6-4bdc-b3f4-4feefc4009eb\"\r\n/>","sha":"50272d651bab2ec56f3149e7fad91de79048e05a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207400","number":207400,"mergeCommit":{"message":"fix:
[Security:Manage:EntityAnalytics:EntityStore] missing labels on Entity
store page (#207400)\n\nCloses: #205826\r\nCloses:
#205825\r\n\r\n**Description**\r\nImport entities input file upload box
is missing label on entity
store\r\npage.\r\n\r\n**Preconditions**\r\nSecurity -> Manage ->Entity
store page\r\n\r\n**Steps to reproduce**\r\n1. Open Entity store
page\r\n2. Run axe-core through the page\r\n\r\n**Changes made**\r\n1.
added required `aria-label` attributes for mentioned
places\r\n\r\n**Screen**\r\n\r\n<img width=\"1223\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/29a76c2c-76f6-4bdc-b3f4-4feefc4009eb\"\r\n/>","sha":"50272d651bab2ec56f3149e7fad91de79048e05a"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CAWilson94 CAWilson94 CAWilson94 approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Project:Accessibility release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
4 participants
@alexwizp @elasticmachine @kibanamachine @CAWilson94