Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES3] Fix onboarding tiles to new design #208069

Merged
merged 5 commits into from
Jan 24, 2025

Conversation

sphilipse
Copy link
Member

@sphilipse sphilipse commented Jan 23, 2025

Summary

This adapts the onboarding guide for Elasticsearch to:

  • use in-page tiles
  • remember its guide selection in local storage
  • actually switch the code correctly on the start page
Screen.Recording.2025-01-23.at.15.48.16.mov

UPDATED SCREEN RECORDING:

Screen.Recording.2025-01-23.at.19.55.30.mov

@sphilipse sphilipse added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Search backport:version Backport to applied version labels labels Jan 23, 2025
@sphilipse sphilipse requested a review from a team as a code owner January 23, 2025 14:51
Copy link
Contributor

@daveyholler daveyholler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, Sander. A couple of initial feedback requests:

  1. Can we ensure the index prompt is the same width for both "UI" and "Code" views? I'm not digging the changing width
  2. Can we tighten up the spacing on the EuiHorizontalRule? The margin="s/m" prop should help

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
searchIndices 182.5KB 182.4KB -105.0B

History

@sphilipse sphilipse merged commit c6f7416 into elastic:main Jan 24, 2025
9 checks passed
JoseLuisGJ pushed a commit to JoseLuisGJ/kibana that referenced this pull request Jan 27, 2025
## Summary

This adapts the onboarding guide for Elasticsearch to:
- use in-page tiles
- remember its guide selection in local storage
- actually switch the code correctly on the start page



https://github.com/user-attachments/assets/9a23b7a6-828a-4d37-a460-975dd526eafe

UPDATED SCREEN RECORDING:



https://github.com/user-attachments/assets/7526f1d5-b85c-4096-85c5-9cf35b1bd757

---------

Co-authored-by: kibanamachine <[email protected]>
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Jan 28, 2025
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208069 locally

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208069 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 208069 locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport missing Added to PRs automatically when the are determined to be missing a backport. backport:version Backport to applied version labels release_note:skip Skip the PR/issue when compiling release notes Team:Search v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants