-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ES3] Fix onboarding tiles to new design #208069
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good, Sander. A couple of initial feedback requests:
- Can we ensure the index prompt is the same width for both "UI" and "Code" views? I'm not digging the changing width
- Can we tighten up the spacing on the
EuiHorizontalRule
? Themargin="s/m"
prop should help
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
## Summary This adapts the onboarding guide for Elasticsearch to: - use in-page tiles - remember its guide selection in local storage - actually switch the code correctly on the start page https://github.com/user-attachments/assets/9a23b7a6-828a-4d37-a460-975dd526eafe UPDATED SCREEN RECORDING: https://github.com/user-attachments/assets/7526f1d5-b85c-4096-85c5-9cf35b1bd757 --------- Co-authored-by: kibanamachine <[email protected]>
Friendly reminder: Looks like this PR hasn’t been backported yet. |
2 similar comments
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Friendly reminder: Looks like this PR hasn’t been backported yet. |
Summary
This adapts the onboarding guide for Elasticsearch to:
Screen.Recording.2025-01-23.at.15.48.16.mov
UPDATED SCREEN RECORDING:
Screen.Recording.2025-01-23.at.19.55.30.mov