Fix deadlock starting canvas, core_plugins/interpreter and kbn-interpreter in node 10 #26043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistic
added
review
v7.0.0
Team:Presentation
|
Pinging @elastic/kibana-canvas |
w33ble
added
the
Team:Visualizations
|
Pinging @elastic/kibana-app |
mistic
force-pushed
the
fix-canvas-deadlock-on-node10
branch
from
f667bc2 to
fa340c2
Compare
mistic
force-pushed
the
fix-canvas-deadlock-on-node10
branch
from
8904158 to
51bcf08
Compare
…s still static analyzable when isolate kbn interpreter.
💔 Build Failed |
|
Closed in favor of #26068 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced by #25711 makes my #25157 PR to hang without any error (just waiting forever) when running
yarn start.The cause is basically related with the fact that on
canvas/initwe wereawait getServerRegistries()and the function to fulfil the returned promise was supposed to be ran bycore_plugins/interpreter/initonawait populateServerRegistries(['serverFunctions', 'types']);however as canvas is loaded first in Node 10, the server will wait forever in a dead lock.It also fixes a change added to the
base_optimizerand make it owning the build forkbn/interpreter. The base_optimizer should be as generic as possible, so I just created an ignore for the babel_register for thekbn-interpreterand turn the public responsible for it owns build using the babel-cli.