Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test fix] - Adds authentication_realm and lookup_realm to the list of expected keys #26470

Merged
merged 2 commits into from
Nov 30, 2018
Merged

[test fix] - Adds authentication_realm and lookup_realm to the list of expected keys #26470

merged 2 commits into from
Nov 30, 2018

Conversation

legrego
Copy link
Member

@legrego legrego commented Nov 30, 2018

Summary

Fixes test failures caused by unexpected realm properties being returned on the authenticate api.

@legrego legrego added non-issue Indicates to automation that a pull request should not appear in the release notes v7.0.0 Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v6.6.0 labels Nov 30, 2018
@legrego legrego requested a review from azasypkin November 30, 2018 15:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@elasticmachine
Copy link
Contributor

💔 Build Failed

azasypkin
azasypkin approved these changes Nov 30, 2018
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Presumably CI will be red for a number for other reasons, so if x-pack security tests are passing I believe we're good to merge this.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@legrego
Copy link
Member Author

legrego commented Nov 30, 2018

Thanks @azasypkin - the remaining failures appear unrelated, so I'll merge!

@legrego legrego merged commit 7248d23 into elastic:master Nov 30, 2018
@legrego legrego deleted the security/fix-auth-api-tests branch November 30, 2018 17:11
@legrego legrego mentioned this pull request Dec 3, 2018
Merged
legrego added a commit to legrego/kibana that referenced this pull request Dec 3, 2018
@legrego
[test fix] - Adds authentication_realm and lookup_realm to the list o…
fead403 
…f expected keys (elastic#26470)

* adds authentication_realm and lookup_realm to the list of expected keys

* update saml tests
legrego added a commit that referenced this pull request Dec 3, 2018
@legrego
[6.x] [test fix] - Adds authentication_realm and lookup_realm to the …
5f8ce1c 
…list of expected keys (#26470) (#26540)

Backports the following commits to 6.x:
 - [test fix] - Adds authentication_realm and lookup_realm to the list of expected keys  (#26470)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
non-issue Indicates to automation that a pull request should not appear in the release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v6.6.0 v7.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legrego @elasticmachine @azasypkin