Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing from /_xpack/security/ to /_security/ #26922

Merged
merged 3 commits into from
Dec 18, 2018

Conversation

kobelb
Copy link
Contributor

@kobelb kobelb commented Dec 10, 2018

This won't pass CI, nor should it be merged before elastic/elasticsearch#36293

@kobelb kobelb added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Dec 10, 2018
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security

@kobelb kobelb added v7.0.0 v6.6.0 non-issue Indicates to automation that a pull request should not appear in the release notes labels Dec 10, 2018
@elasticmachine
Copy link
Contributor

💔 Build Failed

@kobelb
Copy link
Contributor Author

kobelb commented Dec 12, 2018

retest

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kobelb kobelb requested a review from legrego December 17, 2018 20:51
Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the process for getting the x-pack/plugins/console_extensions/spec/generated/* files updated? I assume it's automated in some way, based on the file path

@kobelb
Copy link
Contributor Author

kobelb commented Dec 17, 2018

@bmcconaghy is kind enough to take care of this for us: #27057

Copy link
Member

@legrego legrego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bmcconaghy bmcconaghy merged commit 2fa3cd8 into elastic:master Dec 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-issue Indicates to automation that a pull request should not appear in the release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v6.6.0 v7.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants