-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Monitoring] Fixing issue with EUI table filtering in monitoring UI #27504
Merged
chrisronline
merged 10 commits into
elastic:master
from
chrisronline:monitoring/eui_filtering_tables
Jan 9, 2019
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
087afc6
Ensure the schema is set
chrisronline 234ca48
Merge remote-tracking branch 'elastic/master' into monitoring/eui_fil…
chrisronline f027450
Merge remote-tracking branch 'elastic/master' into monitoring/eui_fil…
chrisronline 173c79b
Flatten certain table data lists to ensure the default field filterin…
chrisronline bc8fc42
Fix issue with tests
chrisronline 1284478
Merge remote-tracking branch 'elastic/master' into monitoring/eui_fil…
chrisronline e135f87
Fix issue with sort key name
chrisronline 87526da
Merge remote-tracking branch 'elastic/master' into monitoring/eui_fil…
chrisronline 98dba3b
Merge remote-tracking branch 'elastic/master' into monitoring/eui_fil…
chrisronline 520a4f6
Readd localization that was removed
chrisronline File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't find any issues related to this but I'm curious about what it's accomplishing. It doesn't conform to the proptypes specified in the docs, so for my own purposes I'm wondering what it does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, so I'm just allowing any future monitoring tables to specify a schema manually, but if they didn't, set the
schema
property to true so the EUI code does it automatically.