-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS Metricbeat Module Home Tutorial #29488
Conversation
💚 Build Succeeded |
💚 Build Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, this is looking great! Tested it manually 👍
I think it would make sense to clarify that this is retrieving AWS EC2 metrics for now. Maybe not in the title (AWS metrics) but in the descriptions. What do you think?
}), | ||
category: TUTORIAL_CATEGORY.METRICS, | ||
shortDescription: i18n.translate('kbn.server.tutorials.awsMetrics.shortDescription', { | ||
defaultMessage: 'Fetch monitoring metrics from the aws apis and cloudwatch.', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would update case to ... AWS APIs and CloudWatch
src/legacy/core_plugins/kibana/server/tutorials/aws_metrics/index.js
Outdated
Show resolved
Hide resolved
@exekias Yeah I debated about that. So we can add AWS EC2 for now and then after we introduced more metricsets, we will remove it? |
💚 Build Succeeded |
Yes! let's not forget about it when the module grows 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The following comments don't have to be addressed in this PR.
For the future we should check if we want to add some more commands to the getting started as the AWS module requires the credential as otherwise it does not work. We could at least post a hint or doc here so users don't get lost.
Nit: The dashboard button looks not very nice lower case. Should it be AWS?
💚 Build Succeeded |
@ruflin Yeah the only thing it has right now is |
Summary
This PR is to add AWS metricbeat module home tutorial as a part of elastic/beats#9300
![screen shot 2019-01-29 at 4 23 21 pm](https://user-images.githubusercontent.com/14081635/51947478-45ac1f80-23e2-11e9-992f-461c68ce40de.png)
Screenshot 1:
AWS metrics
showed up on home tutorial pageScreenshot 2: AWS tutorial page correctly
![screen shot 2019-01-29 at 10 19 43 am](https://user-images.githubusercontent.com/14081635/51927101-04028100-23b0-11e9-94a7-f913555a960c.png)
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers