Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS Metricbeat Module Home Tutorial #29488

Merged
merged 5 commits into from
Jan 30, 2019

Conversation

kaiyan-sheng
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng commented Jan 29, 2019

Summary

This PR is to add AWS metricbeat module home tutorial as a part of elastic/beats#9300
Screenshot 1: AWS metrics showed up on home tutorial page
screen shot 2019-01-29 at 4 23 21 pm

Screenshot 2: AWS tutorial page correctly
screen shot 2019-01-29 at 10 19 43 am

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@kaiyan-sheng kaiyan-sheng added the WIP Work in progress label Jan 29, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kaiyan-sheng kaiyan-sheng self-assigned this Jan 29, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kaiyan-sheng kaiyan-sheng added review and removed WIP Work in progress labels Jan 29, 2019
Copy link
Contributor

@exekias exekias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work, this is looking great! Tested it manually 👍

I think it would make sense to clarify that this is retrieving AWS EC2 metrics for now. Maybe not in the title (AWS metrics) but in the descriptions. What do you think?

}),
category: TUTORIAL_CATEGORY.METRICS,
shortDescription: i18n.translate('kbn.server.tutorials.awsMetrics.shortDescription', {
defaultMessage: 'Fetch monitoring metrics from the aws apis and cloudwatch.',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would update case to ... AWS APIs and CloudWatch

@kaiyan-sheng
Copy link
Contributor Author

nice work, this is looking great! Tested it manually 👍

I think it would make sense to clarify that this is retrieving AWS EC2 metrics for now. Maybe not in the title (AWS metrics) but in the descriptions. What do you think?

@exekias Yeah I debated about that. So we can add AWS EC2 for now and then after we introduced more metricsets, we will remove it?

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@exekias
Copy link
Contributor

exekias commented Jan 30, 2019

Yes! let's not forget about it when the module grows 😄

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The following comments don't have to be addressed in this PR.

For the future we should check if we want to add some more commands to the getting started as the AWS module requires the credential as otherwise it does not work. We could at least post a hint or doc here so users don't get lost.

Nit: The dashboard button looks not very nice lower case. Should it be AWS?

screenshot 2019-01-30 at 11 55 56

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@kaiyan-sheng
Copy link
Contributor Author

@ruflin Yeah the only thing it has right now is Modify the settings in the modules.d/aws.yml file. I will merge this PR first and then open a new PR to add more requirements. Thanks.

@kaiyan-sheng kaiyan-sheng merged commit 6e04960 into elastic:master Jan 30, 2019
@kaiyan-sheng kaiyan-sheng deleted the add_aws_tutorial branch January 30, 2019 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants