-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable reporting tests on 6.x #29666
Conversation
💔 Build Failed |
Failing Test: Error: expected 500 to equal 200 Is this because it is not supported, the test needs fixing or a real failure? |
Phantom should still be supported in 6.7. I am not aware of any specific reasons those api tests shouldn't work. |
There was an issue previously that broke these tests, I'll have to dig it up in history and find out what it was. I'll take a look and see! |
#26789 is part of the work to re-enable the chromium ones after a functional breakage. @tsullivan do you recall the nature around why these tests broke? I'm fuzzy on the details since it's been a bit |
Much of it seemed be general flakiness: the tests staged a lot of concurrent reporting jobs, and in ESQueue, an instance of Kibana will claim whatever it can. I broke up the tests to only stage 2-3 jobs at a time. Since this PR is needed, it looks like there was a missed backport |
Is there anything I can do on this? I'm not sure entirely what needs to be backported, otherwise happy to do so |
@liza-mae can you change this to enable just the chromium tests? I think the Phantom tests might need some updates before they can be called fixed. Phantom is not in master, that's one reason for 6.x and master being different. |
Thanks @tsullivan I removed phantom tests. |
💚 Build Succeeded |
💚 Build Succeeded |
I am not sure why these tests are disabled in 6.x branch, would like to re-enable them if there is nothing blocking them from running. Is phantom still supported in 6.7?
Issue #29529