Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand add panels flyout and increase default rows per page #30508

Merged
merged 49 commits into from
Feb 12, 2019
Merged
Show file tree
Hide file tree
Changes from 48 commits
Commits
Show all changes
49 commits
Select commit Hold shift + click to select a range
1d14b1f
WIP typings for saved object client
timroes Feb 4, 2019
d3a7cb6
Move more files to TS
timroes Feb 4, 2019
a755c2a
type saved objects client
flash1293 Feb 4, 2019
dcbcc41
clean up typings for saved object client
flash1293 Feb 5, 2019
605ec60
tie typings form server and client for saved objects together
flash1293 Feb 5, 2019
830fd7f
add missing html import typing to x-pack
timroes Feb 5, 2019
96a8922
Add missing buildSourcePatterns
timroes Feb 5, 2019
c5fccaa
Removed accidental comma
timroes Feb 5, 2019
6f9e95f
WIP typings for saved object client
timroes Feb 4, 2019
526046c
Move more files to TS
timroes Feb 4, 2019
cacc55f
type saved objects client
flash1293 Feb 4, 2019
d991a93
clean up typings for saved object client
flash1293 Feb 5, 2019
63b6fd9
tie typings form server and client for saved objects together
flash1293 Feb 5, 2019
ddbe49e
add types for saved_object_finder
flash1293 Feb 5, 2019
b04e950
remove unnecessary setState updater function
flash1293 Feb 5, 2019
78e400a
Merge remote-tracking branch 'upstream/master' into ts-saved-object-c…
flash1293 Feb 5, 2019
93e1d77
add typings for saved_object_client tests and fix test cases
flash1293 Feb 5, 2019
3eaf2c3
Merge branch 'ts-saved-object-client' into chore/tsify-saved-object-f…
flash1293 Feb 5, 2019
e71e163
refine types for saved_object_finder
flash1293 Feb 5, 2019
41ff9a5
duplicate case_conversion helpers for the moment
flash1293 Feb 6, 2019
588bbf7
Merge branch 'ts-saved-object-client' into chore/tsify-saved-object-f…
flash1293 Feb 6, 2019
d2b966a
Merge remote-tracking branch 'upstream/master' into chore/tsify-saved…
flash1293 Feb 6, 2019
3b437e9
rename ismounted flag
flash1293 Feb 6, 2019
46a1c78
improve saved_object_finder typings
flash1293 Feb 6, 2019
b9bc2ff
Merge branch 'master' into ts-saved-object-client
timroes Feb 6, 2019
8afcd38
Remove only marker form unit tests
mikecote Feb 6, 2019
39b1bf3
Address PR review
timroes Feb 6, 2019
0e0c428
Fix some documentation
timroes Feb 6, 2019
919d5d0
Replace ts-ignore by any imports
timroes Feb 6, 2019
8699c2a
Remove expect.js from test
timroes Feb 6, 2019
46d1828
Merge remote-tracking branch 'upstream/master' into ts-saved-object-c…
flash1293 Feb 7, 2019
4a2f779
Merge branch 'ts-saved-object-client' into chore/tsify-saved-object-f…
flash1293 Feb 7, 2019
5a76d95
Merge remote-tracking branch 'upstream/master' into chore/tsify-saved…
flash1293 Feb 7, 2019
7e66b7a
fix ts errors
flash1293 Feb 7, 2019
c32eab9
remove any
flash1293 Feb 8, 2019
6884b42
adress review notes
flash1293 Feb 8, 2019
3d20d99
make add panel flyout wider
flash1293 Feb 8, 2019
e636441
fix typing of registry
flash1293 Feb 8, 2019
803883d
Merge branch 'chore/tsify-saved-object-finder' into fix/add-panel-ove…
flash1293 Feb 8, 2019
71df162
small type improvement
flash1293 Feb 8, 2019
6ba2d2e
Merge branch 'chore/tsify-saved-object-finder' into fix/add-panel-ove…
flash1293 Feb 8, 2019
356932f
remove unused typings
flash1293 Feb 8, 2019
cab8819
Merge remote-tracking branch 'upstream/master' into fix/add-panel-ove…
flash1293 Feb 8, 2019
e1851bd
increase pagesize in saved object finder and make it configurable
flash1293 Feb 8, 2019
290982a
Merge remote-tracking branch 'upstream/master' into fix/add-panel-ove…
flash1293 Feb 8, 2019
a3808eb
change max rows per page
flash1293 Feb 8, 2019
4e21308
Merge branch 'chore/tsify-saved-object-finder' into fix/add-panel-ove…
flash1293 Feb 8, 2019
5cd6d68
fix snapshot test
flash1293 Feb 8, 2019
13ea7fe
Merge remote-tracking branch 'upstream/master' into fix/add-panel-ove…
flash1293 Feb 12, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ exports[`render 1`] = `
maxWidth={false}
onClose={[Function]}
ownFocus={true}
size="s"
size="m"
>
<EuiFlyoutBody>
<EuiTitle
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,6 @@ class DashboardAddPanelUi extends React.Component {
<EuiFlyout
ownFocus
onClose={this.props.onClose}
size="s"
data-test-subj="dashboardAddPanel"
>
<EuiFlyoutBody>
Expand Down
1 change: 1 addition & 0 deletions src/server/saved_objects/service/saved_objects_client.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ export interface FindOptions extends BaseOptions {
search?: string;
searchFields?: string[];
hasReference?: { type: string; id: string };
defaultSearchOperator?: 'AND' | 'OR';
}

export interface FindResponse<T extends SavedObjectAttributes = any> {
Expand Down
25 changes: 25 additions & 0 deletions src/ui/public/registry/vis_types.d.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
/*
* Licensed to Elasticsearch B.V. under one or more contributor
* license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright
* ownership. Elasticsearch B.V. licenses this file to you under
* the Apache License, Version 2.0 (the "License"); you may
* not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing,
* software distributed under the License is distributed on an
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
* KIND, either express or implied. See the License for the
* specific language governing permissions and limitations
* under the License.
*/

import { VisType } from '../vis';
import { UIRegistry } from './_registry';

declare type VisTypesRegistryProvider = UIRegistry<VisType> & {
byName: { [typeName: string]: VisType };
};
Loading