Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dateHistogramInterval utility #37108

Closed
wants to merge 17 commits into from
Closed

Add dateHistogramInterval utility #37108

wants to merge 17 commits into from

Conversation

timroes
Copy link
Contributor

@timroes timroes commented May 24, 2019 •
edited
Loading

Summary

TBD

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch

@elasticmachine

This comment has been minimized.

Sign in to view
@lukeelmers lukeelmers force-pushed the date-histogram-util branch from 3262406 to a0cf0b6 Compare May 30, 2019 23:10
@elasticmachine

This comment has been minimized.

Sign in to view
@lukeelmers lukeelmers force-pushed the date-histogram-util branch from a0cf0b6 to edf5f16 Compare May 31, 2019 16:28
@elasticmachine
Copy link
Contributor

💔 Build Failed

@lukeelmers
Copy link
Member

lukeelmers commented Jun 1, 2019 •
edited
Loading 

           └-: point series
             └-> "before all" hook
             └-> "before all" hook: initChart
               └- ✖ fail: "visualize app  point series "before all" hook: initChart"

^ This remaining functional test failure seems legit. Console error in the browser says:

InvalidEsIntervalFormatError: Invalid interval format: 0ms

@lukeelmers lukeelmers force-pushed the date-histogram-util branch from edf5f16 to d71a3ce Compare June 3, 2019 04:21
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

timroes
timroes commented Jun 4, 2019
View reviewed changes
x-pack/test_utils/jest/config.js Outdated
@@ -20,6 +20,7 @@ export default {
'server/**/*.js',
],
moduleNameMapper: {
'^plugins/([^\/.]*)(.*)': '<rootDir>/src/legacy/core_plugins/$1/public$2',
'^ui/(.*)': '<rootDir>**/public/$1',
'\\.(jpg|jpeg|png|gif|eot|otf|webp|svg|ttf|woff|woff2|mp4|webm|wav|mp3|m4a|aac|oga)$': '<rootDir>/src/dev/jest/mocks/file_mock.js',
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this module map would never have worked, since it should refer to <rootDir>/../src/dev/... since the root dir of the x-pack tests is the x-pack folder itself? cc @spalger

@flash1293 flash1293 mentioned this pull request Jun 4, 2019
Merged
7 tasks
@elasticmachine

This comment has been minimized.

Sign in to view
@timroes
Copy link
Contributor Author

timroes commented Jun 4, 2019

Jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@lukeelmers lukeelmers mentioned this pull request Jun 10, 2019
Closed
@elasticmachine
Copy link
Contributor

💔 Build Failed

@timroes
Copy link
Contributor Author

timroes commented Jun 17, 2019

Close in favor of #39091

@timroes timroes closed this Jun 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@timroes timroes

@lukeelmers lukeelmers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timroes @elasticmachine @lukeelmers