Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable renovate for developer doc generators. #38239

Merged
merged 2 commits into from
Jun 7, 2019

Conversation

mshustov
Copy link
Contributor

@mshustov mshustov commented Jun 6, 2019

Summary

  • we have to regenerate docs on a version update. otherwise in the upcoming PR when API changed we have tons of unrelated changes in the docs Route tags #37344
  • those tools are quite unstable and there are no tests in Kibana. we cannot make sure everything works properly.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@mshustov mshustov added chore Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team Feature:New Platform labels Jun 6, 2019
@mshustov mshustov requested review from rudolf and a team June 6, 2019 08:12
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations

@mshustov
Copy link
Contributor Author

mshustov commented Jun 6, 2019

btw which team is responsible for updating dependencies? how can we get the latest typescript version? the update will require some manual work
@elastic/kibana-platform @elastic/kibana-operations

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

renovate.json5 Outdated Show resolved Hide resolved
@spalger
Copy link
Contributor

spalger commented Jun 7, 2019

Operations is handling dependency updates by default, but any team can handle them if they like! I'll probably handle the typescript update once I've made it through the smaller, simpler updates.

Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mshustov mshustov merged commit cb375f2 into elastic:master Jun 7, 2019
@mshustov mshustov deleted the disable-renovate-for-docs branch June 7, 2019 15:01
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Team:Operations Team label for Operations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants