Broken: update Storybook dependencies #38856
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintandrewhall
force-pushed
the
upgrade-storybook
branch
from
b36e3f4 to
2111fa3
Compare
💚 Build Succeeded |
💚 Build Succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the Storybook dependencies in
x-packcauses a tremendous amount of churn in theyarn.lockfile. Kibana and Canvas continue to function, but Kibana in IE 11 is broken:I've tried to play around with giving Storybook its own
package.jsonbut had very limited success. With the amount of improvements SB makes in any given week, we can't afford to have this kind of churn in our dependencies.Advice appreciated.
cc: @spalger @streamich