[Logs UI] Add link from the sample web logs to the Logs UI #42635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zacqary
added
release_note:enhancement
v8.0.0
Feature:Logs UI
|
Pinging @elastic/infra-logs-ui |
Zacqary
commented
Aug 5, 2019
| @@ -67,8 +67,15 @@ export function infra(kibana: any) { | |||
| config(Joi: typeof JoiNamespace) { | |||
| return getConfigSchema(Joi); | |||
| }, | |||
| init(server: KbnServer) { | |||
| init(server: any) { | |||
There was a problem hiding this comment.
This follows the same convention used in other plugins that call server.addAppLinksToSampleDataset
There was a problem hiding this comment.
So according to LegacyPluginOptions that function should have the signature of InitPluginFunction and server should be of type Server. APM's index.ts file seems to be close to the "right way". We can either fix this now by expanding the scope of your PR or fix it in a follow up PR. Either way, I think we should fix it so the typing works as expected.
See: https://github.com/elastic/kibana/blob/master/src/legacy/plugin_discovery/types.ts#L87
💔 Build Failed |
|
retest |
💔 Build Failed |
💚 Build Succeeded |
simianhacker
approved these changes
Aug 8, 2019
There was a problem hiding this comment.
Everything looks good. As far as the typing goes, I will let you make the call on how you want to proceed. If you decide to fix it in this PR then just request a "re-review" and I will take another look.
oo_________oooo___oooooooo_ooo_____ooo_
oo_______oo____oo____oo____oooo___oooo_
oo______oo___________oo____oo_oo_oo_oo_
oo______oo____ooo____oo____oo__ooo__oo_
oo_______oo____oo____oo____oo_______oo_
ooooooo____oooo______oo____oo_______oo_
_______________________________________
💚 Build Succeeded |
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Aug 13, 2019
…p-metrics-selectall * 'master' of github.com:elastic/kibana: (27 commits) [ML] Data Frames: Analytics job creation. (elastic#43102) [Vis Default editor] Fix issue with Rollup (elastic#42430) [Vis: Default editor] EUIficate Markdown tab (elastic#42677) [New Platform Migration Phase I]: update dateHisogramInterval & parseEsInterval imports (elastic#42917) [Infra UI] Add AWS metrics to node detail page (elastic#42153) update apm index pattern (elastic#43106) [SIEM] Toggle Column / Code Coverage and Cypress (elastic#42766) skip failing test (elastic#43163) [code] Add option to turn the go dependency download on/off. (elastic#43096) disable visual regression jobs Removed dead code (elastic#42774) fixes csv export of saved searches that have _source field (elastic#43123) Export missing Context types (elastic#43051) Update dependency supports-color to v7 (elastic#43064) switch to icon type string instead of node (elastic#43111) [Maps] Enable borders for icon symbols (elastic#43066) [ftr] enable visualRegression jobs (elastic#42989) [ML] Converting single to multi metric job (elastic#42532) fix(NA): dont clean dll module if it is a package json file (elastic#42904) [Logs UI] Add link from the sample web logs to the Logs UI (elastic#42635) ...
Kerry350
pushed a commit
to Kerry350/kibana
that referenced
this pull request
Sep 16, 2019
…2635) * [Logs UI] Add link from the sample web logs to the Logs UI * Add i18n
Kerry350
pushed a commit
to Kerry350/kibana
that referenced
this pull request
Sep 16, 2019
…2635) * [Logs UI] Add link from the sample web logs to the Logs UI * Add i18n
Kerry350
added a commit
that referenced
this pull request
Sep 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes #40687
Adds a link to the Logs UI from the sample data card:
Not sure how to get it to display at the top of the list, as the content and order of the list items is retrieved from the server. Dashboard seems to be at the top no matter what, and the order of the rest appear in whichever order their respective plugins register.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers