Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flakiness in request lib tests #42647

Merged
merged 6 commits into from
Aug 6, 2019
Merged

Fix flakiness in request lib tests #42647

merged 6 commits into from
Aug 6, 2019

Conversation

cjcenizal
Copy link
Contributor

Fixes #42561
Fixes #42563
Fixes #42562
Fixes #42225

@cjcenizal cjcenizal added v8.0.0 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v7.4.0 test-unit labels Aug 5, 2019
@cjcenizal cjcenizal requested a review from sebelga August 5, 2019 23:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui

@cjcenizal cjcenizal added the release_note:skip Skip the PR/issue when compiling release notes label Aug 5, 2019
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal force-pushed the tests/flaky-request-lib branch from e588875 to f354522 Compare August 6, 2019 00:06
@elasticmachine
Copy link
Contributor

💔 Build Failed

@cjcenizal
Copy link
Contributor Author

The failure was unrelated: deprecation_warnings·js.config/deprecation warnings mixin logs deprecation warnings when using outdated config.

@cjcenizal
Copy link
Contributor Author

Retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal
Copy link
Contributor Author

Retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal
Copy link
Contributor Author

These tests have run over 120 times without a failure, so I believe their flakiness has been resolved.

@elasticmachine
Copy link
Contributor

💔 Build Failed

sebelga
sebelga approved these changes Aug 6, 2019
View reviewed changes
Copy link
Contributor

@sebelga sebelga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Did not test locally, what it the script we need to run to execute tests in this folder?

@cjcenizal
Copy link
Contributor Author

Thanks @sebelga! The command is:

node scripts/jest es_ui_shared

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@cjcenizal cjcenizal merged commit c571d2f into elastic:master Aug 6, 2019
@cjcenizal cjcenizal deleted the tests/flaky-request-lib branch August 6, 2019 15:48
@cjcenizal cjcenizal mentioned this pull request Aug 6, 2019
Merged
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Aug 6, 2019
@cjcenizal
Fix flakiness in request lib tests (elastic#42647)
2161b00 
* Remove flakiness from 'pollIntervalMs' test by making timing irrelevant.
* Remove flakiness from 'state' tests by increasing wait time.
* Fix flakiness with 'resets the pollIntervalMs' test by increasing the wait time.
cjcenizal added a commit that referenced this pull request Aug 6, 2019
@cjcenizal
Fix flakiness in request lib tests (#42647) (#42711)
2dd0c61 
* Remove flakiness from 'pollIntervalMs' test by making timing irrelevant.
* Remove flakiness from 'state' tests by increasing wait time.
* Fix flakiness with 'resets the pollIntervalMs' test by increasing the wait time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sebelga sebelga sebelga approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more test-unit v7.4.0 v8.0.0
Projects
None yet
Milestone
No milestone
3 participants
@cjcenizal @elasticmachine @sebelga