Convert to TypeScript ui/field_formats #44370

alexwizp · 2019-08-29T10:51:36Z

Partially fix #43439

Summary

What was done in this PR:

Convert to TypeScript
Convert tests from Mocha to Jest

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

alexwizp · 2019-09-02T20:43:42Z

retest

elasticmachine · 2019-09-02T22:15:16Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

ppisljar

LGTM, tested on chrome linux

elasticmachine · 2019-09-03T12:22:16Z

Pinging @elastic/kibana-app-arch

lizozom

Tested and working.

Added some TS questions.

src/legacy/ui/field_formats/converters/custom.ts

lizozom · 2019-09-03T13:37:59Z

src/legacy/ui/field_formats/content_types/html_content_type.ts

+// @ts-ignore
+import { getHighlightHtml } from '../../../core_plugins/kibana/common/highlight/highlight_html';
+
+type HtmlConventTypeConvert = (


Could we TS this better?

I've added interface for Field property.

src/legacy/ui/field_formats/field_format.ts

src/legacy/ui/field_formats/content_types/text_content_type.ts

src/legacy/ui/field_formats/types.ts

lizozom · 2019-09-03T13:52:33Z

src/legacy/ui/field_formats/types.ts

+
+export type ContentType = 'html' | 'text';
+
+export interface IFieldFormat {


// brain-pick

Could we benefit from using generics here?

Not sure that we should use generics here.

Please see:

elasticmachine · 2019-09-03T17:54:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

src/legacy/ui/field_formats/converters/custom.ts

src/legacy/ui/field_formats/field_format.ts

lizozom

LGTM

elasticmachine · 2019-09-04T11:20:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

rayafratkina · 2019-09-04T15:29:48Z

@elastic/ml-ui can you please take a look?

walterra

ML changes LGTM

* Convert to TypeScript ui/field_formats * Fix PR comments * Fix PR comments

alexwizp requested a review from gospodarsky August 29, 2019 11:02

alexwizp changed the title ~~Convert to TypeScript ui/field_formats~~ [WIP] Convert to TypeScript ui/field_formats Aug 29, 2019

alexwizp added the WIP Work in progress label Aug 29, 2019

alexwizp self-assigned this Aug 29, 2019

alexwizp force-pushed the ui/field_formats branch from dcf39ff to 27efc29 Compare August 29, 2019 12:51

alexwizp requested a review from a team as a code owner August 29, 2019 12:51

alexwizp force-pushed the ui/field_formats branch 2 times, most recently from 34a46c0 to f15f0fb Compare August 30, 2019 10:46

elastic deleted a comment from elasticmachine Aug 30, 2019

alexwizp added the release_note:skip Skip the PR/issue when compiling release notes label Aug 30, 2019

alexwizp force-pushed the ui/field_formats branch from f15f0fb to a4d79be Compare August 30, 2019 13:17

elastic deleted a comment from elasticmachine Aug 30, 2019

alexwizp force-pushed the ui/field_formats branch from a4d79be to ca56356 Compare August 30, 2019 14:49

elastic deleted a comment from elasticmachine Aug 30, 2019

alexwizp force-pushed the ui/field_formats branch from ca56356 to de5a9e3 Compare August 30, 2019 15:22

streamich mentioned this pull request Aug 30, 2019

ui/field_formats 👉 src/plugins/data #43439

Closed

7 tasks

alexwizp force-pushed the ui/field_formats branch 4 times, most recently from cfa5373 to b782282 Compare September 2, 2019 11:11

elastic deleted a comment from elasticmachine Sep 2, 2019

lizozom self-requested a review September 2, 2019 12:25

elastic deleted a comment from elasticmachine Sep 2, 2019

alexwizp force-pushed the ui/field_formats branch from 52057fe to a8b07e5 Compare September 2, 2019 14:27

elastic deleted a comment from elasticmachine Sep 2, 2019

alexwizp force-pushed the ui/field_formats branch from a8b07e5 to e5be702 Compare September 2, 2019 15:03

alexwizp force-pushed the ui/field_formats branch from e5be702 to 079c00a Compare September 2, 2019 18:54

Convert to TypeScript ui/field_formats

1017234

alexwizp force-pushed the ui/field_formats branch from 079c00a to 1017234 Compare September 2, 2019 19:36

myasonik requested review from ppisljar and lukeelmers September 3, 2019 08:43

ppisljar approved these changes Sep 3, 2019

View reviewed changes

alexwizp added Feature:FieldFormatters Feature:NP Migration Team:AppArch and removed WIP Work in progress labels Sep 3, 2019

alexwizp added v7.5.0 v8.0.0 labels Sep 3, 2019

lizozom suggested changes Sep 3, 2019

View reviewed changes

Fix PR comments

2ffe554

alexwizp force-pushed the ui/field_formats branch from 9be1870 to 2ffe554 Compare September 3, 2019 16:09

lukeelmers reviewed Sep 4, 2019

View reviewed changes

src/legacy/ui/field_formats/converters/custom.ts Show resolved Hide resolved

src/legacy/ui/field_formats/field_format.ts Outdated Show resolved Hide resolved

lizozom approved these changes Sep 4, 2019

View reviewed changes

Fix PR comments

c3474a3

walterra approved these changes Sep 4, 2019

View reviewed changes

alexwizp merged commit b5d59c2 into elastic:master Sep 5, 2019

alexwizp added a commit to alexwizp/kibana that referenced this pull request Sep 5, 2019

Convert to TypeScript ui/field_formats (elastic#44370)

eec0731

* Convert to TypeScript ui/field_formats * Fix PR comments * Fix PR comments

alexwizp mentioned this pull request Sep 5, 2019

[7.x] Convert to TypeScript ui/field_formats (#44370) #44854

Merged

alexwizp added a commit that referenced this pull request Sep 5, 2019

Convert to TypeScript ui/field_formats (#44370) (#44854)

20b8ea6

* Convert to TypeScript ui/field_formats * Fix PR comments * Fix PR comments

alexwizp deleted the ui/field_formats branch January 4, 2020 08:18

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Convert to TypeScript ui/field_formats #44370

Convert to TypeScript ui/field_formats #44370

alexwizp commented Aug 29, 2019 •

edited

Loading

alexwizp commented Sep 2, 2019

elasticmachine commented Sep 2, 2019

ppisljar left a comment

elasticmachine commented Sep 3, 2019

lizozom left a comment

lizozom Sep 3, 2019

alexwizp Sep 3, 2019

lizozom Sep 3, 2019

alexwizp Sep 3, 2019

elasticmachine commented Sep 3, 2019

lizozom left a comment

elasticmachine commented Sep 4, 2019

rayafratkina commented Sep 4, 2019

walterra left a comment


		export type ContentType = 'html' \| 'text';

		export interface IFieldFormat {

Convert to TypeScript ui/field_formats #44370

Convert to TypeScript ui/field_formats #44370

Conversation

alexwizp commented Aug 29, 2019 • edited Loading

Summary

Checklist

For maintainers

alexwizp commented Sep 2, 2019

elasticmachine commented Sep 2, 2019

💚 Build Succeeded

ppisljar left a comment

Choose a reason for hiding this comment

elasticmachine commented Sep 3, 2019

lizozom left a comment

Choose a reason for hiding this comment

lizozom Sep 3, 2019

Choose a reason for hiding this comment

alexwizp Sep 3, 2019

Choose a reason for hiding this comment

lizozom Sep 3, 2019

Choose a reason for hiding this comment

alexwizp Sep 3, 2019

Choose a reason for hiding this comment

elasticmachine commented Sep 3, 2019

💚 Build Succeeded

lizozom left a comment

Choose a reason for hiding this comment

elasticmachine commented Sep 4, 2019

💚 Build Succeeded

rayafratkina commented Sep 4, 2019

walterra left a comment

Choose a reason for hiding this comment

alexwizp commented Aug 29, 2019 •

edited

Loading