Allow replacing visualizations on dashboard #45095

friol · 2019-09-07T10:09:30Z

Summary

As asked in Issue #43900, this PR adds the "Replace visualization" function to the Edit Menu when a Dashboard is in edit mode. The new visualization is chosen from a flyout, and replaces the old one with the same position and dimensions.

elasticmachine · 2019-09-07T10:09:32Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticmachine · 2019-09-07T10:09:32Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticmachine · 2019-09-11T19:45:39Z

Pinging @elastic/kibana-app

TinaHeiligers · 2019-09-16T18:06:32Z

jenkins test this

elasticmachine · 2019-09-16T18:53:34Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

…ngeview

friol · 2019-09-18T05:46:14Z

@TinaHeiligers : can you please run the build again?

ryankeairns

LGTM from the design side. A Kibana engineer will need to complete a code review / approval before merging.

This is a really nice addition, simple and very intuitive. The interaction does exactly what I would expect - clicking the action link opens the flyout, allowing me to choose as a new viz. Thanks for the PR!

timroes · 2019-09-18T15:21:53Z

@stacey-gammon Since the embeddable layer is still rather new, could we perhaps bother you for a review here?

timroes · 2019-09-18T15:22:03Z

Jenkins, test this

stacey-gammon · 2019-09-18T16:45:17Z

This is awesome! You might have to update some things after #44707 is merged, hopefully today. I am out tomorrow and Friday and I'm not sure I'll be able to finish the review today but if not I'll get back around to it early next week.

elasticmachine · 2019-09-18T16:57:05Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

friol · 2019-09-18T17:35:30Z

@stacey-gammon : the type_check script fails for this error:

ERROR x-pack failed
src/legacy/core_plugins/dashboard_embeddable_container/public/np_ready/public/index.ts:20:42 - error TS2307: Cannot find module 'kibana/public'.
20 import { PluginInitializerContext } from 'kibana/public';

But the error is not in files I've touched. The same line of code is also on master:

https://github.com/elastic/kibana/blob/master/src/legacy/core_plugins/dashboard_embeddable_container/public/np_ready/public/index.ts

Edit: this was before the merge of #44707.

timroes · 2019-09-20T12:37:30Z

Jenkins, test this

elasticmachine · 2019-09-20T14:17:49Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

friol · 2019-09-20T14:26:28Z

@timroes : error is not in my code, is it?

stacey-gammon · 2019-09-23T13:14:27Z

@friol , it's probably that something in jest is now importing that file that wasn't before. Those imports don't work in jenkins unfortunately so the recommendation is still relative file paths (discussed here: #40446). We eventually we want to move to support these short file imports, and they are still scattered about the code because they don't always cause failures. Short term fix is to just switch to a relative file path import.

friol · 2019-09-23T14:53:02Z

@friol , it's probably that something in jest is now importing that file that wasn't before. Those imports don't work in jenkins unfortunately so the recommendation is still relative file paths (discussed here: #40446). We eventually we want to move to support these short file imports, and they are still scattered about the code because they don't always cause failures. Short term fix is to just switch to a relative file path import.

@stacey-gammon : ok, so, exactly, what should I do?

…s type check

…ngeview

friol · 2019-10-16T21:46:15Z

Thanks @friol ! Someone from the @elastic/kibana-app team should be picking this up soon to help with tests. It's got an LGTM from me for the embeddable part of it.

Oh one thing I did think of though this weekend - it should probably be displayed as "Replace panel" not "Replace visualization" since you could swap it out with different types of embeddables, and the term "visualization" is specific to the one type. We also have "map" and "saved search", may eventually have "input control", and others.

@stacey-gammon : I renamed the menu item to "Replace panel". To be honest, one would have to change all the file names and all the object names to "change_panel_something"... but I hope you won't need that :)

nickofthyme · 2019-10-18T19:41:32Z

@friol Thanks for jumping on this so quickly I thought of this feature just a few months ago!

I updated the naming to replacePanel just to be consistent across the board.

I couldn't find any issue with the test you pointed out, tbd if the ci passes 🤞.

I also added some functional tests to your PR. Please let me know if you have any comments witht the changes and feel free to make any changes you'd like.

nickofthyme

Code LGTM, Thanks for this enhancement! I Love it!

elasticmachine · 2019-10-18T21:02:29Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 8034d10

friol · 2019-10-18T21:40:10Z

@friol Thanks for jumping on this so quickly I thought of this feature just a few months ago!

I updated the naming to replacePanel just to be consistent across the board.

I couldn't find any issue with the test you pointed out, tbd if the ci passes 🤞.

I also added some functional tests to your PR. Please let me know if you have any comments witht the changes and feel free to make any changes you'd like.

@nickofthyme : simply great! You had the patience to rename all the objects to "replacePanel*" :)
Many thanks - I don't have any comments, it's ok to me.

elasticmachine · 2019-10-18T22:47:26Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: e8dceea

nickofthyme · 2019-10-23T14:50:43Z

@elasticmachine merge upstream

nickofthyme · 2019-10-23T14:57:16Z

retest

elasticmachine · 2019-10-23T16:14:44Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 61b2ade

friol · 2019-10-23T17:13:52Z

@nickofthyme : tell me we can finally merge this one! It's 1 month and 15 days old :)

nickofthyme · 2019-10-23T22:06:59Z

@friol Done! Thanks again for all the help!

friol · 2019-10-24T05:10:08Z

@nickofthyme : there is another PR from me, dated 28 august, that got "lost" -> #35379 .
Would you mind reviewing it? I think that functionality would be quite useful.
Thanks

* First version of change view functionality * Adds the 'replace view' functionality to dashboard edit mode * Fixed type_check errors * Make action part of dashboard_embeddable_container * Fixed import paths for type check errors * Fixed i18n errors * Renamed action to 'Replace panel' and adjusted jest tests to pass type check * test: add functional tests Closes elastic#43900

…9173) * First version of change view functionality * Adds the 'replace view' functionality to dashboard edit mode * Fixed type_check errors * Make action part of dashboard_embeddable_container * Fixed import paths for type check errors * Fixed i18n errors * Renamed action to 'Replace panel' and adjusted jest tests to pass type check * test: add functional tests Closes #43900

elasticmachine · 2019-10-24T13:44:26Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 61b2ade

nickofthyme · 2019-10-24T13:49:56Z

@friol I'll take a look at #35379.

FYI this feature will be in the 7.6.0 release, just missed 7.5.0 😞

friol · 2019-10-24T17:30:16Z

@friol I'll take a look at #35379.

FYI this feature will be in the 7.6.0 release, just missed 7.5.0 😞

@nickofthyme : thanks!

friol added 2 commits September 6, 2019 17:07

First version of change view functionality

66fe6d1

Adds the 'replace view' functionality to dashboard edit mode

fd67640

rayafratkina added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 11, 2019

friol mentioned this pull request Sep 16, 2019

Custom space avatar images #45148

Merged

friol added 4 commits September 17, 2019 12:03

Merge remote-tracking branch 'upstream/master' into changeview

7d9ec00

Merge branch 'changeview' of https://github.com/friol/kibana into cha…

352d771

…ngeview

Merge remote-tracking branch 'upstream/master' into changeview

ac273a3

Fixed type_check errors

6cf0f5b

Merge remote-tracking branch 'upstream/master' into changeview

c06558f

ryankeairns self-requested a review September 18, 2019 14:58

ryankeairns approved these changes Sep 18, 2019

View reviewed changes

timroes requested a review from stacey-gammon September 18, 2019 15:21

friol added 2 commits September 19, 2019 07:07

Merge remote-tracking branch 'upstream/master' into changeview

5ce9f56

Changes to adapt to PR elastic#44707

07390f3

friol added 2 commits October 16, 2019 23:43

Renamed menu action to 'Replace panel', adjusted the jest test to pas…

46abe9d

…s type check

Merge branch 'changeview' of https://github.com/friol/kibana into cha…

22a6007

…ngeview

nickofthyme added 3 commits October 18, 2019 14:37

refactor: update action naming

e153651

test: add functional tests to pr 45095

9bb2646

Merge branch 'upstream/master' into changeview

8034d10

nickofthyme approved these changes Oct 18, 2019

View reviewed changes

test: isolate replace panel tests, add saved search replacement

e8dceea

Merge branch 'master' into changeview

61b2ade

nickofthyme added Feature:Dashboard Dashboard related features and removed v7.5.0 labels Oct 23, 2019

nickofthyme merged commit c718972 into elastic:master Oct 23, 2019

timroes added the v7.6.0 label Oct 24, 2019

timroes mentioned this pull request Oct 24, 2019

[7.x] Add ability to replace any panel in edit mode on the fly (#45095) #49173

Merged

timroes changed the title ~~GUI enhancement: ability to replace a view on the fly~~ Allow replacing visualizations on dashboard Oct 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow replacing visualizations on dashboard #45095

Allow replacing visualizations on dashboard #45095

friol commented Sep 7, 2019

elasticmachine commented Sep 7, 2019

elasticmachine commented Sep 7, 2019

elasticmachine commented Sep 11, 2019

TinaHeiligers commented Sep 16, 2019

elasticmachine commented Sep 16, 2019

friol commented Sep 18, 2019

ryankeairns left a comment •

edited

Loading

timroes commented Sep 18, 2019

timroes commented Sep 18, 2019

stacey-gammon commented Sep 18, 2019

elasticmachine commented Sep 18, 2019

friol commented Sep 18, 2019 •

edited

Loading

timroes commented Sep 20, 2019

elasticmachine commented Sep 20, 2019

friol commented Sep 20, 2019

stacey-gammon commented Sep 23, 2019

friol commented Sep 23, 2019

friol commented Oct 16, 2019

nickofthyme commented Oct 18, 2019 •

edited

Loading

nickofthyme left a comment

elasticmachine commented Oct 18, 2019

friol commented Oct 18, 2019

elasticmachine commented Oct 18, 2019

nickofthyme commented Oct 23, 2019

nickofthyme commented Oct 23, 2019

elasticmachine commented Oct 23, 2019

friol commented Oct 23, 2019

nickofthyme commented Oct 23, 2019

friol commented Oct 24, 2019

elasticmachine commented Oct 24, 2019

nickofthyme commented Oct 24, 2019

friol commented Oct 24, 2019

Allow replacing visualizations on dashboard #45095

Allow replacing visualizations on dashboard #45095

Conversation

friol commented Sep 7, 2019

Summary

elasticmachine commented Sep 7, 2019

elasticmachine commented Sep 7, 2019

elasticmachine commented Sep 11, 2019

TinaHeiligers commented Sep 16, 2019

elasticmachine commented Sep 16, 2019

💔 Build Failed

friol commented Sep 18, 2019

ryankeairns left a comment • edited Loading

Choose a reason for hiding this comment

timroes commented Sep 18, 2019

timroes commented Sep 18, 2019

stacey-gammon commented Sep 18, 2019

elasticmachine commented Sep 18, 2019

💔 Build Failed

friol commented Sep 18, 2019 • edited Loading

timroes commented Sep 20, 2019

elasticmachine commented Sep 20, 2019

💔 Build Failed

friol commented Sep 20, 2019

stacey-gammon commented Sep 23, 2019

friol commented Sep 23, 2019

friol commented Oct 16, 2019

nickofthyme commented Oct 18, 2019 • edited Loading

nickofthyme left a comment

Choose a reason for hiding this comment

elasticmachine commented Oct 18, 2019

💔 Build Failed

friol commented Oct 18, 2019

elasticmachine commented Oct 18, 2019

💔 Build Failed

nickofthyme commented Oct 23, 2019

nickofthyme commented Oct 23, 2019

elasticmachine commented Oct 23, 2019

💚 Build Succeeded

friol commented Oct 23, 2019

nickofthyme commented Oct 23, 2019

friol commented Oct 24, 2019

elasticmachine commented Oct 24, 2019

💚 Build Succeeded

nickofthyme commented Oct 24, 2019

friol commented Oct 24, 2019

ryankeairns left a comment •

edited

Loading

friol commented Sep 18, 2019 •

edited

Loading

nickofthyme commented Oct 18, 2019 •

edited

Loading