Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Single Metric Viewer: Fix focus chart updating. #45146

Merged
merged 1 commit into from
Sep 10, 2019
Merged

[ML] Single Metric Viewer: Fix focus chart updating. #45146

merged 1 commit into from
Sep 10, 2019

Conversation

walterra
Copy link
Contributor

@walterra walterra commented Sep 9, 2019 •
edited
Loading

Summary

Part of #42909.

  • Restores the behavior of the angularjs version which only updates the focus chart once all data is loaded. The chart area itself doesn't have a loading indicator, but now we pass on the loading state of single metric viewer as a prop to TimeseriesChart. TimeseriesChart mostly wraps d3 code and we now trigger a re-render only if loading is false.
  • Triggers the overall loading indicator when the focus chart reloads
  • Fixes to pass in values for the progress bar as numbers instead of strings.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@walterra walterra added bug Fixes for quality problems that affect the customer experience regression :ml Feature:Anomaly Detection ML anomaly detection v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v7.5.0 labels Sep 9, 2019
@walterra walterra requested a review from a team as a code owner September 9, 2019 15:11
@walterra walterra self-assigned this Sep 9, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

peteharverson
peteharverson approved these changes Sep 9, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, including IE11, and LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

darnautov
darnautov approved these changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@walterra walterra merged commit d130dbf into elastic:master Sep 10, 2019
@walterra walterra deleted the ml-fix-focus-chart-updating-2 branch September 10, 2019 08:32
walterra added a commit to walterra/kibana that referenced this pull request Sep 10, 2019
@walterra
[ML] Fix focus chart updating. (elastic#45146)
214aef4 
- Restores the behavior of the angularjs version which only updates the focus chart once all data is loaded. The chart area itself doesn't have a loading indicator, but now we pass on the loading state of single metric viewer as a prop to TimeseriesChart. TimeseriesChart mostly wraps d3 code and we now trigger a re-render only if loading is false.
- Triggers the overall loading indicator when the focus chart reloads
- Fixes to pass in values for the progress bar as numbers instead of strings.
@walterra walterra mentioned this pull request Sep 10, 2019
Merged
walterra added a commit to walterra/kibana that referenced this pull request Sep 10, 2019
@walterra
[ML] Fix focus chart updating. (elastic#45146)
dbab7ad 
- Restores the behavior of the angularjs version which only updates the focus chart once all data is loaded. The chart area itself doesn't have a loading indicator, but now we pass on the loading state of single metric viewer as a prop to TimeseriesChart. TimeseriesChart mostly wraps d3 code and we now trigger a re-render only if loading is false.
- Triggers the overall loading indicator when the focus chart reloads
- Fixes to pass in values for the progress bar as numbers instead of strings.
@walterra walterra mentioned this pull request Sep 10, 2019
Merged
walterra added a commit that referenced this pull request Sep 10, 2019
@walterra
[ML] Fix focus chart updating. (#45146) (#45242)
d37bb60 
- Restores the behavior of the angularjs version which only updates the focus chart once all data is loaded. The chart area itself doesn't have a loading indicator, but now we pass on the loading state of single metric viewer as a prop to TimeseriesChart. TimeseriesChart mostly wraps d3 code and we now trigger a re-render only if loading is false.
- Triggers the overall loading indicator when the focus chart reloads
- Fixes to pass in values for the progress bar as numbers instead of strings.
walterra added a commit that referenced this pull request Sep 10, 2019
@walterra
[ML] Fix focus chart updating. (#45146) (#45243)
9e0a53b 
- Restores the behavior of the angularjs version which only updates the focus chart once all data is loaded. The chart area itself doesn't have a loading indicator, but now we pass on the loading state of single metric viewer as a prop to TimeseriesChart. TimeseriesChart mostly wraps d3 code and we now trigger a re-render only if loading is false.
- Triggers the overall loading indicator when the focus chart reloads
- Fixes to pass in values for the progress bar as numbers instead of strings.
jloleysens added a commit to jloleysens/kibana that referenced this pull request Sep 10, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into chore/console…
d1824b3 
…-to-np-ready

* 'master' of github.com:elastic/kibana: (138 commits)
  [Canvas] i18n work on workpad header (and a few header CTAs) and convert to typescript (elastic#44943)
  update close/delete system index modals (elastic#45037)
  TS return type of createIndexPatternSelect (elastic#45107)
  [ML] Fix focus chart updating. (elastic#45146)
  [ML] Data frame transform: Fix progress in wizard create step. (elastic#45116)
  [Graph] Re-enable functional test (elastic#44683)
  [SIEM] unique table id for each top talkers table (elastic#45014)
  [SIEM] ip details heading draggable (elastic#45179)
  [Maps][File upload] Set complete on index pattern creation (elastic#44423)
  [Maps] unmount map embeddable component on destroy (elastic#45183)
  [SIEM] Adds error toasts to MapEmbeddable component (elastic#45088)
  fix redirect to maintain search query string (elastic#45184)
  [APM] One-line trace summary (elastic#44842)
  [Infra UI] Display non-metric details on Node Detail page (elastic#43551)
  [Maps][File upload] Removing bbox from parsed file pending upstream lib fix (elastic#45194)
  [Logs UI] Improve live streaming behavior when scrolling (elastic#44923)
  [APM] Fix indefinite loading state in agent settings for unauthorized user roles (elastic#44970)
  [Reporting] Rewrite addForceNowQuerystring to getFullUrls (elastic#44851)
  [Reporting/ESQueue] Improve logging of doc-update events (elastic#45077)
  [Reporting] Make screenshot capture less noisy by default (elastic#45185)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darnautov darnautov darnautov approved these changes

@peteharverson peteharverson peteharverson approved these changes

@pheyos pheyos Awaiting requested review from pheyos

@jgowdyelastic jgowdyelastic Awaiting requested review from jgowdyelastic

Assignees

@walterra walterra

Labels
bug Fixes for quality problems that affect the customer experience Feature:Anomaly Detection ML anomaly detection :ml regression release_note:skip Skip the PR/issue when compiling release notes v7.4.0 v7.5.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@walterra @elasticmachine @darnautov @peteharverson