[ML] Removes EUI super date picker custom fix, it's now in EUI itself. #45246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
:ml
Feature:Anomaly Detection
walterra
requested review from
darnautov,
alvarezmelissa87 and
jgowdyelastic
|
Pinging @elastic/ml-ui |
💔 Build Failed |
💔 Build Failed |
darnautov
approved these changes
Sep 17, 2019
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Sep 20, 2019
walterra
added a commit
that referenced
this pull request
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Follow up to #45052 (EUI update) and #44860 (ML custom code fix).
The EUI fixes done in elastic/eui#2250 and elastic/eui#2298 are part of EUI
13.8.1so we can remove our own custom code.Note: EUI
13.8.1is not merged tomasteryet so the updated tests are expected to fail. Once the EUI update is inmasterand updated in this branch the tests are expected to pass.Our custom fix will stay in
7.4, this is going into7.5.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers