Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable visual tests #47861

Merged
merged 25 commits into from
Oct 30, 2019
Merged

Enable visual tests #47861

merged 25 commits into from
Oct 30, 2019

Conversation

liza-mae
Copy link
Contributor

No description provided.

@liza-mae liza-mae added release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.4.1 labels Oct 10, 2019
@liza-mae liza-mae self-assigned this Oct 10, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae liza-mae requested a review from spalger October 11, 2019 15:26
@spalger
Copy link
Contributor

spalger commented Oct 11, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae liza-mae requested a review from a team as a code owner October 14, 2019 15:20
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

retest

@liza-mae
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae
Copy link
Contributor Author

retest

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

spalger
spalger approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@spalger spalger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little nit, but LGTM on green!

x-pack/test/visual_regression/config.js Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@liza-mae liza-mae merged commit 56c32a2 into elastic:master Oct 30, 2019
@liza-mae liza-mae deleted the liza/enable-visual-tests branch October 30, 2019 20:19
@liza-mae liza-mae mentioned this pull request Oct 30, 2019
Merged
liza-mae added a commit to liza-mae/kibana that referenced this pull request Oct 30, 2019
@liza-mae
Enable visual tests (elastic#47861)
8b6057f 
* Enable visual tests

* Uncomment visual tests jobs

* More testing - use dev token and only run visual tests

* Fix dev token

* Fix token again

* Skip infra tests

* Set style of table

* Try setting discover sample size

* Fix Jenkinsfile

* Remove login_page test from config (it skipped but failing)

* Remove line

* Prep to merge, revert token and update Jenkinsfile

* Try skipping at Security level, instead of removing from config
@liza-mae liza-mae mentioned this pull request Oct 30, 2019
Merged
liza-mae added a commit to liza-mae/kibana that referenced this pull request Oct 30, 2019
@liza-mae
Enable visual tests (elastic#47861)
4ab7e0a 
* Enable visual tests

* Uncomment visual tests jobs

* More testing - use dev token and only run visual tests

* Fix dev token

* Fix token again

* Skip infra tests

* Set style of table

* Try setting discover sample size

* Fix Jenkinsfile

* Remove login_page test from config (it skipped but failing)

* Remove line

* Prep to merge, revert token and update Jenkinsfile

* Try skipping at Security level, instead of removing from config
@liza-mae liza-mae mentioned this pull request Oct 30, 2019
Merged
liza-mae added a commit to liza-mae/kibana that referenced this pull request Oct 30, 2019
@liza-mae
Enable visual tests (elastic#47861)
9c7e657 
* Enable visual tests

* Uncomment visual tests jobs

* More testing - use dev token and only run visual tests

* Fix dev token

* Fix token again

* Skip infra tests

* Set style of table

* Try setting discover sample size

* Fix Jenkinsfile

* Remove login_page test from config (it skipped but failing)

* Remove line

* Prep to merge, revert token and update Jenkinsfile

* Try skipping at Security level, instead of removing from config
liza-mae added a commit that referenced this pull request Oct 31, 2019
@liza-mae
Enable visual tests (#47861) (#49805)
59b545e 
* Enable visual tests

* Uncomment visual tests jobs

* More testing - use dev token and only run visual tests

* Fix dev token

* Fix token again

* Skip infra tests

* Set style of table

* Try setting discover sample size

* Fix Jenkinsfile

* Remove login_page test from config (it skipped but failing)

* Remove line

* Prep to merge, revert token and update Jenkinsfile

* Try skipping at Security level, instead of removing from config
liza-mae added a commit that referenced this pull request Oct 31, 2019
@liza-mae
Enable visual tests (#47861) (#49804)
37caa67 
* Enable visual tests

* Uncomment visual tests jobs

* More testing - use dev token and only run visual tests

* Fix dev token

* Fix token again

* Skip infra tests

* Set style of table

* Try setting discover sample size

* Fix Jenkinsfile

* Remove login_page test from config (it skipped but failing)

* Remove line

* Prep to merge, revert token and update Jenkinsfile

* Try skipping at Security level, instead of removing from config
liza-mae added a commit that referenced this pull request Oct 31, 2019
@liza-mae
Enable visual tests (#47861) (#49800)
b2f42c1 
* Enable visual tests

* Uncomment visual tests jobs

* More testing - use dev token and only run visual tests

* Fix dev token

* Fix token again

* Skip infra tests

* Set style of table

* Try setting discover sample size

* Fix Jenkinsfile

* Remove login_page test from config (it skipped but failing)

* Remove line

* Prep to merge, revert token and update Jenkinsfile

* Try skipping at Security level, instead of removing from config
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spalger spalger spalger approved these changes

Assignees

@liza-mae liza-mae

Labels
release_note:skip Skip the PR/issue when compiling release notes v7.4.2 v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@liza-mae @elasticmachine @spalger