Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fleet] unenroll agent from the details page #48286
[Fleet] unenroll agent from the details page #48286
Changes from all commits
be640f3
12b998e
211caca
5c8f1c7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this component could be written as a provider pattern that could be used from any UI, for any number of agents (useful as we will need unenroll in the agent list view, at least!).
an example "delete policy(ies)" modal used in Snapshot and Restore: policy_delete_provider.tsx. note that it handles modal open state, making request for deletion, and displaying toast notification for failure/success within the component. then it can be used for multiple delete and single delete anywhere!
what do you think of this pattern? just want to see if you like or dislike the pattern. no need to change in this PR unless you want to 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eh I have seen this pattern go well, and I have seen it get super messy. For now my vote would be to keep is simple.
As long term things like this for fleet have the potential to be exposed throughout kibana, I would like to see us not over think this for now until we get through the next phase and see better where fleet will be going
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not really familiar with this pattern, maybe something we can refactor while implementing unenrolling in the listing,