use embeddables in visualize editor #48744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
💔 Build Failed
|
ppisljar
force-pushed
the
visualizeUseEmbeddable
branch
from
09ec4d2 to
bee1062
Compare
💔 Build Failed
|
ppisljar
force-pushed
the
visualizeUseEmbeddable
branch
from
bee1062 to
cffdf8a
Compare
💔 Build Failed
|
ppisljar
force-pushed
the
visualizeUseEmbeddable
branch
from
cffdf8a to
b0555fa
Compare
💔 Build Failed
|
ppisljar
force-pushed
the
visualizeUseEmbeddable
branch
from
b0555fa to
2321bfb
Compare
💔 Build Failed
|
|
retest |
|
jenkins, test this |
ppisljar
force-pushed
the
visualizeUseEmbeddable
branch
2 times, most recently
from
8b301c2 to
90ff0bb
Compare
ppisljar
added
the
release_note:skip
💔 Build Failed
|
💚 Build Succeeded
|
flash1293
requested changes
Oct 24, 2019
| $scope.renderFunction = async () => { | ||
| if (!$scope._handler) { | ||
| $scope._handler = await embeddables.getEmbeddableFactory('visualization').createFromObject($scope.savedObj, { | ||
| //vis: $scope.savedObj.vis.getUiState(), |
| @@ -101,7 +101,7 @@ export default function ({ getService, getPageObjects }) { | |||
| expect(rowData).to.have.string('Sep 21, 2015 @ 11:59:22.316'); | |||
| }); | |||
|
|
|||
| it('should modify the time range when the histogram is brushed', async function () { | |||
| it.skip('should modify the time range when the histogram is brushed', async function () { | |||
There was a problem hiding this comment.
I think this got fixed on master
| @@ -57,7 +58,7 @@ const defaultEditor = function ($rootScope, $compile) { | |||
| } | |||
| } | |||
|
|
|||
| render({ uiState, timeRange, filters, appState }) { | |||
| render({ uiState, timeRange, filters, query }) { | |||
There was a problem hiding this comment.
what's the difference? Relying on getAppState instead of using the one that got passed in seems like a step backwards into angular code.
There was a problem hiding this comment.
we need to get rid of appState all together, so it doesn't make much difference here.
| @@ -69,6 +73,7 @@ export interface VisualizeOutput extends EmbeddableOutput { | |||
| export class VisualizeEmbeddable extends Embeddable<VisualizeInput, VisualizeOutput> { | |||
| private savedVisualization: VisSavedObject; | |||
| private loader: VisualizeLoader; | |||
| private appState: any; | |||
There was a problem hiding this comment.
Looks like this is PersistedState | undefined
ppisljar
force-pushed
the
visualizeUseEmbeddable
branch
from
3de1f62 to
904c931
Compare
💚 Build Succeeded |
💚 Build Succeeded |
flash1293
approved these changes
Oct 29, 2019
ppisljar
added a commit
to ppisljar/kibana
that referenced
this pull request
Oct 29, 2019
ppisljar
added a commit
that referenced
this pull request
Oct 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Makes Visualize app use Embeddable API (instead of visualize loader) to show visualization
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers