[Uptime] Fix chart wrapping for monitor page #49268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinkambic
added
bug
|
Pinging @elastic/uptime (Team:uptime) |
justinkambic
force-pushed
the
uptime_responsive-wrapper
branch
from
2f8fbf7 to
63a2c6c
Compare
💚 Build Succeeded |
💚 Build Succeeded |
andrewvc
reviewed
Oct 29, 2019
| import styled from 'styled-components'; | ||
|
|
||
| const ResponsiveWrapper = styled.div` | ||
| margin-left: 120px; |
There was a problem hiding this comment.
So, is there no EUI way to get this to work in a responsive way?
There was a problem hiding this comment.
You can see this comment for more info about why we have this custom styling here. I can ask someone from EUI to review this as well to see if they have a better recommendation.
There was a problem hiding this comment.
For more clarification, we wanted to introduce additional whitespace to balance out the view a bit, and because there wasn't enough separation in the default mobile view. In essence we're still using EUI's styling, just customizing it slightly. I've asked the EUI team to give us feedback on this though.
This was referenced Oct 30, 2019
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Oct 30, 2019
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Oct 30, 2019
justinkambic
added a commit
that referenced
this pull request
Oct 31, 2019
justinkambic
added a commit
that referenced
this pull request
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #49243.
Extracts the responsive wrapping functionality we previously introduced to a separate component, and allows consuming code to choose between a responsive element or an
EuiPanel.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers