Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Improve processing of groups in data recognizer wizard #49310

Merged
merged 11 commits into from
Oct 31, 2019
Merged

[ML] Improve processing of groups in data recognizer wizard #49310

merged 11 commits into from
Oct 31, 2019

Conversation

darnautov
Copy link
Contributor

@darnautov darnautov commented Oct 25, 2019 •
edited
Loading

Summary

Resolves #48515. Added support for job overrides in recognizer module setup.

Oct-25-2019 14-00-43

Checklist

@darnautov darnautov requested a review from a team as a code owner October 25, 2019 12:03
@darnautov darnautov self-assigned this Oct 25, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@peteharverson peteharverson changed the title Ml 48515 improve job groups processing [ML] Improve processing of groups in data recognizer wizard Oct 25, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@darnautov darnautov force-pushed the ML-48515-improve-job-groups-processing branch from a8f31c6 to 75c3eb3 Compare October 28, 2019 11:16
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

walterra
walterra reviewed Oct 29, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just added some questions.

x-pack/legacy/plugins/ml/public/jobs/new_job_new/recognize/components/edit_job.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/ml/public/jobs/new_job_new/recognize/page.tsx Outdated Show resolved Hide resolved
x-pack/legacy/plugins/ml/common/types/modules.ts Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

walterra
walterra approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest change LGTM.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

alvarezmelissa87
alvarezmelissa87 approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

jgowdyelastic
jgowdyelastic approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Oct 30, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested latest changes and LGTM

@darnautov darnautov force-pushed the ML-48515-improve-job-groups-processing branch from 661d8af to 447ab55 Compare October 30, 2019 14:55
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@darnautov darnautov merged commit c885f3c into elastic:master Oct 31, 2019
@darnautov darnautov deleted the ML-48515-improve-job-groups-processing branch October 31, 2019 07:54
@darnautov darnautov mentioned this pull request Oct 31, 2019
Merged
darnautov added a commit to darnautov/kibana that referenced this pull request Oct 31, 2019
@darnautov
[ML] Improve processing of groups in data recognizer wizard (elastic#…
e3a27c4 
…49310)

* [ML] add support for job overrides

* [ML] disable Save button for invalid form, add translation

* [ML] add a tooltip for edit button

* [ML] fix IE flex layout issue

* [ML] conditionally set jobOverrides to the request payload

* [ML] remove hideCloseButton

* [ML] fix applyJobConfigOverrides

* [ML] processArrayValues

* [ML] check deeper arrays

* [ML] PR remarks

* [ML] check for an empty value
darnautov added a commit that referenced this pull request Oct 31, 2019
@darnautov
[ML] Improve processing of groups in data recognizer wizard (#49310) (#…
5a67403 
…49839)

* [ML] add support for job overrides

* [ML] disable Save button for invalid form, add translation

* [ML] add a tooltip for edit button

* [ML] fix IE flex layout issue

* [ML] conditionally set jobOverrides to the request payload

* [ML] remove hideCloseButton

* [ML] fix applyJobConfigOverrides

* [ML] processArrayValues

* [ML] check deeper arrays

* [ML] PR remarks

* [ML] check for an empty value
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walterra walterra walterra approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@darnautov darnautov

Labels
Feature:Anomaly Detection ML anomaly detection :ml release_note:enhancement v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ML] Improve processing of job groups in data recognizer wizard
6 participants
@darnautov @elasticmachine @walterra @alvarezmelissa87 @peteharverson @jgowdyelastic