[Logs UI] Fix chart and table state loss due to loading indica… #49356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Build Failed
|
weltenwort
force-pushed
the
logs-ui-analysis-results-loading-overlay
branch
from
ad7b5de to
1c81baf
Compare
💚 Build Succeeded |
weltenwort
added
Feature:Logs UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
weltenwort
added
the
release_note:skip
weltenwort
changed the title
weltenwort
changed the title
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Oct 29, 2019
…tic#49356) This changes the result loading indicators of the log rate analysis page such that they are rendered as an overlay to the existing panels. This has the advantage that the page layout doesn't jump during the loading process and the charts and table maintain their filter and expansion states.
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Oct 29, 2019
…tic#49356) This changes the result loading indicators of the log rate analysis page such that they are rendered as an overlay to the existing panels. This has the advantage that the page layout doesn't jump during the loading process and the charts and table maintain their filter and expansion states.
weltenwort
added a commit
that referenced
this pull request
Oct 29, 2019
Backports the following commits to 7.x: - [Logs UI] Fix chart and table state loss due to loading indica… (#49356)
weltenwort
added a commit
that referenced
this pull request
Oct 29, 2019
Backports the following commits to 7.5: - [Logs UI] Fix chart and table state loss due to loading indica… (#49356)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This changes the result loading indicators of the log rate analysis page such that they are rendered as an overlay to the existing panels. This has the advantage that the page layout doesn't jump during the loading process and the charts and table maintain their filter and expansion states.
fixes #48767
Preview
Checklist
Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately