Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Maps] do not re-fetch data on empty filter setting changes #49382

Merged
merged 4 commits into from
Oct 30, 2019
Merged

[Maps] do not re-fetch data on empty filter setting changes #49382

merged 4 commits into from
Oct 30, 2019

Conversation

nreese
Copy link
Contributor

@nreese nreese commented Oct 25, 2019 •
edited
Loading

fixes #49374

Vector layer checks for changes to query before fetching new data, https://github.com/elastic/kibana/blob/master/x-pack/legacy/plugins/maps/public/layers/vector_layer.js#L360. The problem was that the query always changed when setQuery action was dispatched. The reason for this was to support Refresh button where user intentionally wants to re-fetch for the same parameters.

This PR adds a new parameter to setQuery that only changes queryLastTriggeredAt when the intended action is refreshing for the same parameters.

@nreese nreese added release_note:fix [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.6.0 labels Oct 25, 2019
@nreese nreese requested a review from thomasneirynck October 25, 2019 19:13
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

thomasneirynck
thomasneirynck approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx

x-pack/legacy/plugins/maps/public/actions/map_actions.js Outdated Show resolved Hide resolved
x-pack/legacy/plugins/maps/public/actions/map_actions.js Show resolved Hide resolved
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@nreese nreese merged commit 904eb32 into elastic:master Oct 30, 2019
nreese added a commit to nreese/kibana that referenced this pull request Oct 30, 2019
@nreese
[Maps] do not re-fetch data on empty filter setting changes (elastic#…
d07b5d4 
…49382)

* [Maps] do not re-fetch data on empty filter setting changes

* handle case where prev query does not exist

* add parentheses around turnary statement
@nreese nreese mentioned this pull request Oct 30, 2019
Merged
nreese added a commit that referenced this pull request Oct 30, 2019
@nreese
[Maps] do not re-fetch data on empty filter setting changes (#49382) (#…
77f305f 
…49701)

* [Maps] do not re-fetch data on empty filter setting changes

* handle case where prev query does not exist

* add parentheses around turnary statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasneirynck thomasneirynck thomasneirynck approved these changes

Assignees
No one assigned
Labels
[Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation release_note:fix v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maps app tries to fetch data on empty filter setting changes
3 participants
@nreese @elasticmachine @thomasneirynck