[Lens] Remove default title, tweak text for consistency #49394
Conversation
wylieconlon
commented
Oct 25, 2019
wylieconlon
commented
- Change "Lens Visualizations" to "Lens" in visualize grid
- Removes the default title from Lens. The title will only appear if the visualization has been saved previously.
- Move the field type filter to the right, so it doesn't cover the list of fields
- Make Discover wording consistent with Lens
wylieconlon
added
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💔 Build Failed |
| @@ -97,7 +97,7 @@ export function DiscoverFieldSearch({ | |||
| > | |||
| <FormattedMessage | |||
| id="kbn.discover.fieldChooser.fieldFilterFacetButtonLabel" | |||
| defaultMessage="Fields filtered" | |||
| defaultMessage="Filter by type" | |||
There was a problem hiding this comment.
dear @bhavyarm, that's the wording we talked about, do you think it's better this way?
There was a problem hiding this comment.
We previously had this wording in Lens, but it was requested to change by @gchaps - this is at least now consistent
There was a problem hiding this comment.
@kertal thanks for checking in. I discussed it with QA team too. It isn't clear to us at all that Fields filtered means we can change the facets(categories) of the fields. Its not indicating an action - but you can clearly do it on Aggregatable and searchable and type. But we couldn't arrive at something definite. Does adding a tooltip help? In any case - Filter in discover is getting confusing. Because we have data filters and then this which isn't necessarily filtering on data. Thanks!
There was a problem hiding this comment.
But I definitely don't want to get stuck in on this
There was a problem hiding this comment.
I like the idea of adding a tooltip.
There was a problem hiding this comment.
I'm not sure a tooltip improves the clarity of this, since the behavior is pretty discoverable- you can click the button and see what filters are available. I would prefer not introducing different tooltips for Lens and Discover
There was a problem hiding this comment.
What do you think about this way? There's a Search for fields and a Filter fields action, plus we could add a tooltip elaborating the square block displaying the number of active field filters.
| @@ -68,7 +68,7 @@ export function DiscoverFieldSearch({ | |||
| defaultMessage: 'Show field filter settings', | |||
| }); | |||
| const searchPlaceholder = i18n.translate('kbn.discover.fieldChooser.searchPlaceHolder', { | |||
| defaultMessage: 'Search fields', | |||
| defaultMessage: 'Search for fields', | |||
There was a problem hiding this comment.
I prefer the previous, for what little it's worth.
There was a problem hiding this comment.
I talked to @wylieconlon, and he suggested Search field names.
💚 Build Succeeded |
💚 Build Succeeded |
* [Lens] Remove default title, tweak text for consistency * Remove unused * Text update
* [Lens] Remove default title, tweak text for consistency * Remove unused * Text update
|
@wylieconlon in IE11 - lens visualization label doesn't display fully on picking it in create viz wizard. L seems to be cut off. |
|
@bhavyarm Yes, that issue is fixed by this PR |
