Added resize listener after handler was created #49452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igoristic
added
bug
|
Pinging @elastic/stack-monitoring (Team:Monitoring) |
💚 Build Succeeded |
cachedout
approved these changes
Oct 28, 2019
There was a problem hiding this comment.
I can't speak to whether or not this is the right implementation but I tested this functionality and it looks good to me. Nice work, @igoristic
This was referenced Oct 30, 2019
igoristic
added a commit
to igoristic/kibana
that referenced
this pull request
Oct 30, 2019
igoristic
added a commit
that referenced
this pull request
Oct 30, 2019
igoristic
added a commit
that referenced
this pull request
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #49427
The handler did not yet exist when the resize event listener was added, so
_handleResizewas never triggered on resize. This was because the function's behavior became async.This issue can also be reproduced on a Mac environment, but I tested and made sure the fix works on Windows 10 as stated in the ticket