[Graph] Switch to core http #49487
Merged
[Graph] Switch to core http #49487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flash1293
added
Feature:Graph
|
@flash1293 I feel like the |
💚 Build Succeeded |
flash1293
added
the
release_note:skip
|
@elasticmachine merge upstream |
💚 Build Succeeded |
|
@kertal Could you check out this one? It's a really simple cleanup PR. |
kertal
approved these changes
Nov 4, 2019
|
@elasticmachine merge upstream |
💚 Build Succeeded |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Nov 4, 2019
flash1293
added a commit
that referenced
this pull request
Nov 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on
$httpand replaces it withcore.http. It also fixes an issue that caused the loading state to not get cleaned up after a request because the digest cycle wasn't triggered.To do so, I had to replicate the
formatAngularHttpErrorhelper logic. @elastic/kibana-platform it feels like this is a common thing, is/will there be a replacement offered from core and I missed it?