[Logs UI] Fix index checkbox overlap of the analysis setup dat… #49489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weltenwort
added
v8.0.0
Feature:Logs UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
weltenwort
commented
Oct 28, 2019
| </EuiFormControlLayout> | ||
| </EuiFlexGroup> | ||
| </EuiFormRow> | ||
| </EuiDescribedFormGroup> | ||
| ); | ||
| }; | ||
|
|
||
| const WithFixedDatepickerZIndex = euiStyled( |
There was a problem hiding this comment.
I created this function-as-a-child component to work around the issue that the popover class must be specified as popperClassName instead of className.
💚 Build Succeeded |
Zacqary
reviewed
Oct 28, 2019
| </EuiFormControlLayout> | ||
| </EuiFlexGroup> | ||
| </EuiFormRow> | ||
| </EuiDescribedFormGroup> | ||
| ); | ||
| }; | ||
|
|
||
| const WithFixedDatepickerZIndex = euiStyled( |
There was a problem hiding this comment.
Maybe save some complexity by doing:
Suggested change
| const WithFixedDatepickerZIndex = euiStyled( | |
| const StyledDatePicker = euiStyled( | |
| ({ | |
| className, | |
| ...rest, | |
| }: { | |
| className?: string; | |
| rest: Object; // Not sure off the top of my head how to refer to EuiDatePicker's propTypes | |
| }) => <EuiDatePicker {...rest} popperClassName={className}/> | |
| )` | |
| z-index: 3 !important; | |
| `; |
There was a problem hiding this comment.
Ok, I can do something to that effect. The reason why I implemented it as a FAAC component was to avoid that coupling to the datepicker props and retain the ability to supply a className to the datepicker.
weltenwort
force-pushed
the
logs-ui-fix-setup-datepicker-z-index
branch
from
b450005 to
34cb645
Compare
weltenwort
added
the
release_note:skip
💚 Build Succeeded |
|
@Zacqary I followed your suggestion - this is ready for another review pass. |
Zacqary
approved these changes
Oct 29, 2019
weltenwort
changed the title
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Oct 29, 2019
…tic#49489) This slightly increases the datepicker popover `z-index` to avoid the checkbox labels (which for some reason have an increased `z-index`) from underneath showing through. fixes elastic#49245
weltenwort
added a commit
to weltenwort/kibana
that referenced
this pull request
Oct 29, 2019
…tic#49489) This slightly increases the datepicker popover `z-index` to avoid the checkbox labels (which for some reason have an increased `z-index`) from underneath showing through. fixes elastic#49245
weltenwort
added a commit
that referenced
this pull request
Oct 29, 2019
Backports the following commits to 7.x: - [Logs UI] Fix index checkbox overlap of the analysis setup dat… (#49489)
weltenwort
added a commit
that referenced
this pull request
Oct 29, 2019
Backports the following commits to 7.5: - [Logs UI] Fix index checkbox overlap of the analysis setup dat… (#49489)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This slightly increases the datepicker popover
z-indexto avoid the checkbox labels (which for some reason have an increasedz-index) from underneath showing through.fixes #49245
Preview
Checklist
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers
This was checked for breaking API changes and was labeled appropriatelyThis includes a feature addition or change that requires a release note and was labeled appropriately