[Metrics UI] Remove points from charts on Metrics Explorer and Detail Page #49500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bug with metric detail page labels;
simianhacker
added
Feature:Metrics UI
|
Pinging @elastic/logs-metrics-ui (Team:logs-metrics-ui) |
💚 Build Succeeded |
phillipb
reviewed
Oct 28, 2019
| @@ -46,7 +46,7 @@ export const AreaChart = ({ id, color, series, name, type, stack }: Props) => { | |||
| visible: true, | |||
| }, | |||
| point: { | |||
| visible: true, | |||
| visible: false, | |||
There was a problem hiding this comment.
Do you think it might be easy to over look the visible: false part? If we just removed the entire point object, would that make the point disappear also?
…emove-points-from-charts
💚 Build Succeeded |
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Oct 29, 2019
… Page (elastic#49500) * Removing points from Metrics Explorer and Metric Detail Page; Fixing bug with metric detail page labels; * Remove points configuration
simianhacker
added a commit
to simianhacker/kibana
that referenced
this pull request
Oct 29, 2019
… Page (elastic#49500) * Removing points from Metrics Explorer and Metric Detail Page; Fixing bug with metric detail page labels; * Remove points configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR closes #49393 by turning off the points. This also turns off the points on the Metric detail page (linked from the waffle map). While I was fixing this issue I also notice that the labels were not working correctly which is a bug introduced in the Inventory Models PR.
Metrics Explorer
Metric Detail Page
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibility