Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove code-plugin specific build task and related node module #49525

Merged
merged 1 commit into from
Oct 28, 2019

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Oct 28, 2019

With the removal of the code app we missed a module that was only necessary for patching the native modules needed for the code app.

@spalger spalger added Team:Operations Team label for Operations Team v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Oct 28, 2019
@spalger spalger requested a review from tylersmalley October 28, 2019 19:38
@spalger spalger requested a review from a team as a code owner October 28, 2019 19:38
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

@tylersmalley
Copy link
Contributor

tylersmalley commented Oct 28, 2019

Can we also remove CleanCtagBuildTask and @elastic/ctags-langserver while we're here?

@epixa
Copy link
Contributor

epixa commented Oct 28, 2019

FYI we're removing code in 7.5.0 as well, so I assume we'll want to do this there as well.

@epixa epixa added the v7.5.0 label Oct 28, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger
Copy link
Contributor Author

spalger commented Oct 29, 2019

7.x/7.6: a11f180
7.5: 90789cb

@spalger spalger deleted the remove-ununsed-code-code branch October 29, 2019 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Operations Team label for Operations Team v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants