[SIEM] Fix Refresh Button on timeline #49643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XavierM
added
bug
|
Pinging @elastic/siem (Team:SIEM) |
XavierM
changed the title
💚 Build Succeeded |
andrew-goldstein
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
This restores the code from this PR: #47306
Ran locally and verified the behavior matches the pervious (7.4)
LGTM 🚀
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Oct 29, 2019
XavierM
added a commit
to XavierM/kibana
that referenced
this pull request
Oct 29, 2019
💚 Build Succeeded |
XavierM
added a commit
that referenced
this pull request
Oct 30, 2019
XavierM
added a commit
that referenced
this pull request
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves ISSUE
In 7.5 BC 1, the Timeline Refresh button does not submit the KQL query, which is a regression from 7.4.
To reproduce:
Click the SIEM icon in the Kibana left-hand navigation to force a full page refresh
Click the Timeline button to open a (new) Timeline
Enter the following KQL in the Timeline search bar, but don't take any action (yet):
host.name: *
Click the Refresh button in the Timeline
Expected Result
The Timeline displays events
Actual Result
No events are displayed
Click in the Timeline KQL bar to give it focus, then press enter on your keyboard. The events expected to load when Refresh is clicked will be displayed.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] Unit or functional tests were updated or added to match the most common scenarios[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This was checked for breaking API changes and was labeled appropriately[ ] This includes a feature addition or change that requires a release note and was labeled appropriately