use a custom wrapper around chance with longer defaults to avoid conflicts #49653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spalger
added
Team:Operations
|
Pinging @elastic/kibana-operations (Team:Operations) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
added 2 commits
October 30, 2019 11:13
💚 Build Succeeded |
mattapperson
approved these changes
Oct 31, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 31, 2019
…licts (elastic#49653) * use a custom wrapper around chance with longer defaults to avoid conflicts * fix a reference to chance * fix another reference to chance service # Conflicts: # x-pack/test/saml_api_integration/apis/security/saml_login.ts
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 31, 2019
…licts (elastic#49653) * use a custom wrapper around chance with longer defaults to avoid conflicts * fix a reference to chance * fix another reference to chance service # Conflicts: # x-pack/test/saml_api_integration/apis/security/saml_login.ts
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 31, 2019
…licts (elastic#49653) * use a custom wrapper around chance with longer defaults to avoid conflicts * fix a reference to chance * fix another reference to chance service # Conflicts: # x-pack/test/api_integration/services/index.ts # x-pack/test/saml_api_integration/apis/security/saml_login.ts # x-pack/test/saml_api_integration/config.ts # x-pack/test/saml_api_integration/services.ts
spalger
pushed a commit
that referenced
this pull request
Oct 31, 2019
* use a custom wrapper around chance with longer defaults to avoid conflicts (#49653) * use a custom wrapper around chance with longer defaults to avoid conflicts * fix a reference to chance * fix another reference to chance service # Conflicts: # x-pack/test/api_integration/services/index.ts # x-pack/test/saml_api_integration/apis/security/saml_login.ts # x-pack/test/saml_api_integration/config.ts # x-pack/test/saml_api_integration/services.ts * remove 7.4 specific chance reference
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #49650
Fixes #34038
In order to avoid random strings/words that conflict with default identifiers we must specify to
chancethat we want more than the default 1 to 3 syllables. In some cases, like in #49650 and #34038, this causesbarto be generated, which conflicts in these tests. By replacing thechanceservice withrandomnesswe are also avoiding coupling our usage to the chance.js library specifically.