-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Add different request lib to telemetry_analytics
in place of $http
#49671
Merged
justinkambic
merged 4 commits into
elastic:master
from
justinkambic:core_remove-http-from-telemtry-reporter
Oct 31, 2019
Merged
[Core] Add different request lib to telemetry_analytics
in place of $http
#49671
justinkambic
merged 4 commits into
elastic:master
from
justinkambic:core_remove-http-from-telemtry-reporter
Oct 31, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/uptime (Team:uptime) |
telemetry_analytics
in place of $http
telemetry_analytics
in place of $http
Seems to work, passes the smoke test. |
shahzad31
approved these changes
Oct 29, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
💚 Build Succeeded |
💚 Build Succeeded |
@elasticmachine merge upstream |
💚 Build Succeeded |
@elasticmachine merge upstream |
💚 Build Succeeded |
Bamieh
approved these changes
Oct 31, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Oct 31, 2019
… `$http` (elastic#49671) * Add axios to telemetry_analytics in place of . * Remove axios in favor of fetch.
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Oct 31, 2019
… `$http` (elastic#49671) * Add axios to telemetry_analytics in place of . * Remove axios in favor of fetch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Telemetry
release_note:fix
Team:Uptime - DEPRECATED
Synthetics & RUM sub-team of Application Observability
v7.5.0
v7.6.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #49263.
As part of our
7.5
testing we discovered that our routing was broken. This PR aims to address that without breaking the upstream code for other consumers. The existing code is planned to be decommissioned in7.6
anyway, and the ultimate root of the cause is due to an Angular 2 dependency.Testing
There are two main areas to test when evaluating the performance of this patch:
Server
We need to make sure that the report still gets to the server in the same format it was before. Testing this should be pretty straightforward.
master
:master
)console.log()
callClient
You can view the broken functionality on the linked issue. Check that this doesn't happen for you on this patch branch.
Additional concerns
@Bamieh I'm interested in your feedback on the code responsible for the
post
. I imported Axios but if there's a preferred method of doing it please request the change. It seems like most of this code will be deleted in the next release anyway, but I want to make sure we do things appropriately.