Add CockroachDB Metricbeat module to Kibana Home #49672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
v8.0.0
release_note:skip
💚 Build Succeeded |
exekias
reviewed
Oct 30, 2019
| @@ -46,7 +46,7 @@ export function corednsLogsSpecProvider(server, context) { | |||
| learnMoreLink: '{config.docs.beats.filebeat}/filebeat-module-coredns.html', | |||
| }, | |||
| }), | |||
| //TODO: euiIconType: 'logoCoredns', | |||
| euiIconType: '/plugins/kibana/home/tutorial_resources/logos/coredns.svg', | |||
There was a problem hiding this comment.
I understand this is intended, isn't it?
There was a problem hiding this comment.
Yep, I found that the logo was added for metrics but was not being used for logs.
exekias
approved these changes
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add CockroachDB metricbeat module to the Kibana add data UI.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.including a check against IE11Documentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers