[ML] Fixing some of the eslint rule breakages in ML #49716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
requested review from
walterra,
darnautov,
alvarezmelissa87 and
peteharverson
|
Pinging @elastic/ml-ui (:ml) |
jgowdyelastic
added
non-issue
💚 Build Succeeded |
| @@ -198,7 +198,7 @@ function TabStack({ title, items, switchState, switchFunc }) { | |||
|
|
|||
| return ( | |||
| <li key={i} className={className} > | |||
| <a onClick={() => switchFunc(item.index)}>{item.label}</a> | |||
| <a onClick={() => switchFunc(item.index)} onKeyUp={() => {}} >{item.label}</a> | |||
There was a problem hiding this comment.
Do the new rules just require a key event even if it's empty? Seems strange to add an onKeyUp with an empty function. 🤔
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Oct 30, 2019
jgowdyelastic
added a commit
that referenced
this pull request
Oct 31, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes errors for eslint rules:
react-hooks/rules-of-hooksjsx-a11y/click-events-have-key-eventsRelates to #49565
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately