Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] fix bug that fails to match index patterns with leading wildcard #49735

Merged

Conversation

stephmilovic
Copy link
Contributor

@stephmilovic stephmilovic commented Oct 30, 2019

Summary

Resolves https://github.com/elastic/siem-team/issues/373
Fixes a bug that blew up the server when an index pattern with a leading wildcard was passed.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@stephmilovic stephmilovic changed the title fix bug that fails to match index patterns with leading wildcard [SIEM] fix bug that fails to match index patterns with leading wildcard Oct 30, 2019
@spong
Copy link
Member

spong commented Oct 30, 2019

Testing on a Cloud CCS instance containing two clusters: Configuring siem:defaultIndex with *:metricbeat-* instead of monitoring-data:metricbeat-* & house-data:metricbeat-* has the SIEM app loading without error and displaying data from both clusters:

Only monitoring-data:metricbeat-*

image

Only house-data:metricbeat-*

image

All clusters (includes additional host):

image

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@stephmilovic stephmilovic marked this pull request as ready for review October 30, 2019 17:52
Copy link
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out and tested against a CCS cloud deployment and all seems 👍

Tested with the following siem:defaultIndex values:

*beat* - only matches local indices ✅
* - only matches local indices ✅
*:*beat* - only matches cross cluster indices ✅

All these behaviors match that of the Kibana Index Pattern UI, which is what we're shooting for parity wise. LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants