[task-manager] Improve messaging on error due to inline scripts being disabled #49860
Conversation
…nd make error clearer
gmmorris
added
Feature:Task Manager
release_note:skip
|
Pinging @elastic/kibana-stack-services (Team:Stack Services) |
💚 Build Succeeded |
| return docs; | ||
| } catch (ex) { | ||
| if (identifyEsError(ex).includes('cannot execute [inline] scripts')) { | ||
| logger.warn( |
There was a problem hiding this comment.
Do we end up seeing this message over and over? Seems like since it only logs a warning in this case, and then ends up returning [], we'll see this every interval. Should it set some state variable somewhere to indicate "it's never going to work" so we just don't ever try? I guess that doesn't make sense, if they fix ES and start again with Kibana still running. hmmm ...
I guess I woulda expected it to still throw after writing the message, rather than soldier on and return []. Perhaps that a bit fatal-y and we don't want that either?
There was a problem hiding this comment.
It will appear on every poll, but throwing won't prevent that.
My thinking is that throwing will result in polluting the log with both the messaging and the error... feels better to just message what the issue is, no?
As for a global state thing... like you said, it could cause other issues such as ES being sorted but Kibana thinking it can't use TM.
💚 Build Succeeded |
…ng disabled (elastic#49860) This PR detects when claiming tasks fails due to inline scripts being disabled in Elasticsearch and improves the message reported in the Kibana log.
…ng disabled (elastic#49860) This PR detects when claiming tasks fails due to inline scripts being disabled in Elasticsearch and improves the message reported in the Kibana log.
addresses #49853, but doesn't resolve it completely as further mitigation may very likely be required.
Summary
This PR detects when claiming tasks fails due to inline scripts being disabled in Elasticsearch and improves the message reported in the Kibana log.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.This was checked for cross-browser compatibility, including a check against IE11Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsThis was checked for keyboard-only and screenreader accessibilityFor maintainers