Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] Adding cloud specific ML node warning #49861

Closed
wants to merge 11 commits into from
Closed

[ML] Adding cloud specific ML node warning #49861

wants to merge 11 commits into from

Conversation

jgowdyelastic
Copy link
Member

@jgowdyelastic jgowdyelastic commented Oct 31, 2019 •
edited
Loading

Adds a link to the cloud deployment when there are no nodes and kibana is running on cloud.

Text in callout

No ML nodes available
There are no ML nodes available.
You will not be able to create or run jobs.
Please edit your Elastic Cloud deployment and enable a machine learning node.

Can be tested by adding some settings to yml files:
elasticsearch.yml
node.ml: false

kibana.yml
xpack.cloud.id: <supply your own cloud id>

2019-10-31 14-10-55 2019-10-31 14_13_05

Also moves some code about:
removes new_job_defaults.ts in favour of /services/ml_server_info
renames the function loadNewJobDefaults to loadMlServerInfo as more than just new job defaults are being loaded.
new_job_defaults was being deep linked to from other files, so it's best that it's moved to a common location. it also makes sense that the cloud checks to added to this file.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11

For maintainers

- [ ] This was checked for breaking API changes and was labeled appropriately
- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately

@jgowdyelastic jgowdyelastic self-assigned this Oct 31, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes labels Oct 31, 2019
@jgowdyelastic jgowdyelastic marked this pull request as ready for review October 31, 2019 14:27
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner October 31, 2019 14:27
walterra
walterra approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

peteharverson
peteharverson approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sophiec20
Copy link
Contributor

@skearns64 please can we get your review on copy. Thx.

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

alvarezmelissa87
alvarezmelissa87 approved these changes Oct 31, 2019
View reviewed changes
Copy link
Contributor

@alvarezmelissa87 alvarezmelissa87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⚡️

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jgowdyelastic jgowdyelastic force-pushed the adding-cloud-specific-ml-node-warning branch from 500e0b9 to 826299e Compare October 31, 2019 17:18
@elasticmachine
Copy link
Contributor

💔 Build Failed

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jgowdyelastic
Copy link
Member Author

retest

darnautov
darnautov approved these changes Nov 1, 2019
View reviewed changes
Copy link
Contributor

@darnautov darnautov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jgowdyelastic
Copy link
Member Author

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jgowdyelastic jgowdyelastic deleted the adding-cloud-specific-ml-node-warning branch November 1, 2019 13:53
@elasticmachine
Copy link
Contributor

💔 Build Failed

@jgowdyelastic jgowdyelastic mentioned this pull request Nov 12, 2019
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peteharverson peteharverson peteharverson approved these changes

@alvarezmelissa87 alvarezmelissa87 alvarezmelissa87 approved these changes

@darnautov darnautov darnautov approved these changes

@walterra walterra walterra approved these changes

Assignees

@jgowdyelastic jgowdyelastic

Labels
:ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.5.0 v7.6.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jgowdyelastic @elasticmachine @sophiec20 @walterra @darnautov @alvarezmelissa87 @peteharverson