Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[File upload] Switch to index pattern service shim #49893

Merged
merged 7 commits into from
Nov 1, 2019

Conversation

kindsun
Copy link
Contributor

@kindsun kindsun commented Oct 31, 2019

Small PR to switch over to using the New Platform indexPatterns shim in File Upload

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review

@kindsun kindsun added the release_note:skip Skip the PR/issue when compiling release notes label Oct 31, 2019
@kindsun
Copy link
Contributor Author

kindsun commented Oct 31, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Contributor

💔 Build Failed

@kindsun kindsun requested a review from nreese October 31, 2019 22:02
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Copy link
Contributor

@nreese nreese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
code review

@kindsun kindsun merged commit cf03665 into elastic:master Nov 1, 2019
kindsun pushed a commit to kindsun/kibana that referenced this pull request Nov 1, 2019
* Switch to index pattern service shim

* Fix test breaking due to unrelated import in same file

* Move mock and require out of before call to top of file since they're not directly test-related

* Some minor cleanup

* One more thing...
kindsun pushed a commit that referenced this pull request Nov 1, 2019
* Switch to index pattern service shim

* Fix test breaking due to unrelated import in same file

* Move mock and require out of before call to top of file since they're not directly test-related

* Some minor cleanup

* One more thing...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants