Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding NP spaces plugin to CODEOWNERS #49963

Merged
merged 1 commit into from
Nov 1, 2019
Merged

Adding NP spaces plugin to CODEOWNERS #49963

merged 1 commit into from
Nov 1, 2019

Conversation

legrego
Copy link
Member

@legrego legrego commented Nov 1, 2019

Summary

While reviewing #49890, I realized I never added the NP spaces plugin to CODEOWNERS.

@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 1, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego legrego requested a review from a team November 1, 2019 17:43
azasypkin
azasypkin approved these changes Nov 1, 2019
View reviewed changes
Copy link
Member

@azasypkin azasypkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@legrego legrego merged commit 45617f0 into elastic:master Nov 1, 2019
@legrego legrego deleted the spaces/codeowner-np branch November 1, 2019 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azasypkin azasypkin azasypkin approved these changes

Assignees
No one assigned
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@legrego @elasticmachine @azasypkin