Fix: pagination controls should not scroll horizontally for saved search #50764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbondyra
changed the title
mbondyra
added
release_note:fix
Team:Visualizations
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
mbondyra
force-pushed
the
IS_-49757-fix_saved_search_pag_controls_moves_vertical_scrolling
branch
from
e4812fd to
ee4bdb8
Compare
💚 Build Succeeded |
|
Not sure if it is a result of this PR or not, but the pagination overflows the last row in the widget: I haven't tested on master, but without the introduced padding, the pagination controls are back in place:
|
|
Thank you @majagrubic, it's fixed now! |
cchaos
suggested changes
Nov 15, 2019
There was a problem hiding this comment.
Thanks @mbondyra ! Can you also update some of these other hard-coded pixel values to be EUI variables/calculations of these variables? This way our scale stays consistent in case we change the base. I gave suggestions on how to convert them.
| @@ -62,6 +62,16 @@ doc-table { | |||
| margin: $euiSizeXS $euiSizeXS 0; | |||
| } | |||
|
|
|||
| .kbnDocTable__bar--footer { | |||
| position: relative; | |||
| margin: -48px $euiSizeXS 0 0; | |||
There was a problem hiding this comment.
Suggested change
| margin: -48px $euiSizeXS 0 0; | |
| margin: -($euiSize * 3) $euiSizeXS 0 0; |
|
|
||
|
|
||
| .kbnDocTable__padBottom { | ||
| padding-bottom: 32px; |
There was a problem hiding this comment.
Suggested change
| padding-bottom: 32px; | |
| padding-bottom: $euiSizeXL; |
majagrubic
reviewed
Nov 15, 2019
| margin: -($euiSize * 3) $euiSizeXS 0; | ||
| } | ||
|
|
||
|
|
mbondyra
force-pushed
the
IS_-49757-fix_saved_search_pag_controls_moves_vertical_scrolling
branch
from
2dfcd91 to
3f0a162
Compare
💚 Build Succeeded |
|
@elasticmachine merge upstream |
…ves_vertical_scrolling
flash1293
approved these changes
Nov 18, 2019
💚 Build Succeeded |
mbondyra
deleted the
IS_-49757-fix_saved_search_pag_controls_moves_vertical_scrolling
branch
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Dec 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bug: The pagination controls in the header and footer of the saved search widget scroll along with the table.
This PR fixes the problem - the controls keep their position to the right corner of the widget.
Fixes #49757
PS. I use negative margin to include controls from the bottom above the scroll so the design doesn't change. If I haven't, it would look like here:
Another option to 'stick' the position of the controls would be to use JS, but I feel it's too much for this fix. Let me know what you think!
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers