Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SIEM] Add SavedQuery in Timeline - cleanup #50884

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

alexwizp
Copy link
Contributor

Summary

Fix incorrect imports from #49813

For new plugins we can import dependencies only from:

src/plugins/**/public/index.ts
src/plugins/**/server/index.ts

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp alexwizp added Team:SIEM v8.0.0 Team:AppArch release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Nov 18, 2019
@alexwizp alexwizp self-assigned this Nov 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/siem (Team:SIEM)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Copy link
Contributor

@lizozom lizozom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once green

(I already talked about the update way of importing filter \ query utils with @XavierM. We didn't want to create conflicts with the PR you had open last week).

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@alexwizp alexwizp merged commit aed59d6 into elastic:master Nov 18, 2019
alexwizp added a commit to alexwizp/kibana that referenced this pull request Nov 19, 2019
@alexwizp alexwizp deleted the siem-cleanup branch January 4, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.6.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants