Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Clean up uses of deprecated API's in node core (#51431) #52192

Merged
merged 1 commit into from
Dec 4, 2019

Conversation

watson
Copy link
Contributor

@watson watson commented Dec 4, 2019

Backports the following commits to 7.x:

Ensure no deprecated Node.js core API's are used in Kibana. This is
achieved by throwing an error in either development mode or in CI if one
of the deprecated API's is called, and as such, new PR's should no
longer be able to be merged if they use deprecated API's.

Some of these API's (like the `Buffer` constructor`) is a security risk.
@watson watson added the backport label Dec 4, 2019
@watson watson self-assigned this Dec 4, 2019
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@watson watson merged commit 995a914 into elastic:7.x Dec 4, 2019
@watson watson deleted the backport/7.x/pr-51431 branch December 4, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants