-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ML] Single Metric Viewer: Fix full refresh check. #55726
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walterra
added
bug
Fixes for quality problems that affect the customer experience
regression
:ml
Feature:Anomaly Detection
ML anomaly detection
v8.0.0
release_note:skip
Skip the PR/issue when compiling release notes
v7.7.0
v7.6.0
labels
Jan 23, 2020
walterra
requested review from
darnautov,
alvarezmelissa87,
peteharverson and
jgowdyelastic
January 23, 2020 16:40
Pinging @elastic/ml-ui (:ml) |
21 tasks
jgowdyelastic
approved these changes
Jan 23, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code LGTM
💚 Build SucceededTo update your PR or re-run it, just comment with: |
peteharverson
approved these changes
Jan 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and LGTM
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jan 24, 2020
Fixes the check whether to do a full refresh of the page or not. lastRefresh was mistakenly part of the check. This fixes keeping the flyout open for rules editing.
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jan 24, 2020
Fixes the check whether to do a full refresh of the page or not. lastRefresh was mistakenly part of the check. This fixes keeping the flyout open for rules editing.
walterra
added a commit
that referenced
this pull request
Jan 24, 2020
walterra
added a commit
that referenced
this pull request
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Fixes for quality problems that affect the customer experience
Feature:Anomaly Detection
ML anomaly detection
:ml
regression
release_note:skip
Skip the PR/issue when compiling release notes
v7.6.0
v7.7.0
v8.0.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Part of #52986
Fixes the check whether to do a full refresh of the page or not.
lastRefresh
was mistakenly part of the check. This fixes keeping the flyout open for rules editing.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n supportDocumentation was added for features that require explanation or tutorialsUnit or functional tests were updated or added to match the most common scenariosThis was checked for keyboard-only and screenreader accessibilityFor maintainers