Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Monitoring] Support shipping directly to the monitoring cluster #57022

Conversation

chrisronline
Copy link
Contributor

@chrisronline chrisronline commented Feb 6, 2020

Relates to #52639

This PR introduces a new set of monitoring configuration that enable shipping internally collected monitoring data directly to the monitoring cluster.

The settings are:

monitoring.elasticsearch.username
monitoring.elasticsearch.password,
monitoring.elasticsearch.hosts,
...

Before this PR, the only way internally collected monitoring data landed in the monitoring cluster was by going through the production cluster (elasticsearch.* configs).

This PR will ensure Kibana is aligned with the rest of the stack products in preparation for the Metricbeat migration.

TODO

  • We should add additional parity tests that verify both internal collection routes result in equivalent monitoring documents.
  • Handle the production cluster uuid not being available on the batch send

@elasticmachine
Copy link
Contributor

💔 Build Failed

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@streamich streamich added the Team:Monitoring Stack Monitoring team label Feb 7, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/stack-monitoring (Team:Monitoring)

@chrisronline
Copy link
Contributor Author

@elasticmachine merge upstream

@chrisronline chrisronline force-pushed the monitoring/write_to_monitoring_cluster branch from e2e09fe to 403d34f Compare February 10, 2020 21:58
Copy link
Contributor

@igoristic igoristic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor nitpicking, but other than that Great job 👍

@kibanamachine
Copy link
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit e319269 into elastic:master Feb 14, 2020
@chrisronline chrisronline deleted the monitoring/write_to_monitoring_cluster branch February 14, 2020 21:10
chrisronline added a commit to chrisronline/kibana that referenced this pull request Feb 14, 2020
…stic#57022)

* Support shipping directly to the monitoring cluster

* Add timestamp

* PR feedback

* Use utc
chrisronline added a commit that referenced this pull request Feb 14, 2020
) (#57734)

* Support shipping directly to the monitoring cluster

* Add timestamp

* PR feedback

* Use utc
@chrisronline
Copy link
Contributor Author

Backport:

7.x: 63aa613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants